[FYST-1717] Add exemption amounts for Dependent Taxpayers #5481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5481-9939f3a5ea01.herokuapp.com/ |
| @@ -244,7 +244,7 @@ | |||
|
|
|||
| context "exemptions stuff" do | |||
There was a problem hiding this comment.
can we rename this to context "exemptions" do
| xml.Count calculated_fields.fetch(:MD502_LINE_D_COUNT_TOTAL) | ||
| xml.Amount calculated_fields.fetch(:MD502_LINE_D_AMOUNT_TOTAL) | ||
| end | ||
| if has_dependent_exemption? |
There was a problem hiding this comment.
can you add a test for this?
There was a problem hiding this comment.
| xml.Count calculated_fields.fetch(:MD502_LINE_A_COUNT) | ||
| xml.Amount calculated_fields.fetch(:MD502_LINE_A_AMOUNT) | ||
| end | ||
| if has_exemptions? |
There was a problem hiding this comment.
can you also add a test for this?
There was a problem hiding this comment.
anisharamnani
requested changes
Jan 29, 2025
anisharamnani
approved these changes
Jan 30, 2025
DrewProebstel
deleted the
FYST-1717-add-exemption-amounts-for-dependent-taxpayers
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?