FYST-1721 AZ include qual child dependent only if filer is hoh #5475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5475-603a50cda1ce.herokuapp.com/ |
arinchoi03
reviewed
Jan 29, 2025
| @@ -44,7 +44,7 @@ def documents_wrapper | |||
| xml_doc = build_xml_doc("Form140") do |xml| | |||
| xml.LNPriorYrs sanitize_for_xml(@submission.data_source.prior_last_names) | |||
| xml.FilingStatus filing_status | |||
| if hoh_qualifying_person.present? | |||
| if hoh_qualifying_person.present? && @submission.data_source.filing_status_hoh? | |||
There was a problem hiding this comment.
can hoh_qualifying_person exist if filing status is not hoh?
i.e. can we fold in this check into the hoh_qualifying_person logic?
I guess I'm seeing the test coverage and wondering if this is a likely scenario that a :single filer will have an hoh qualifying person.
just return false unless @submission.data_source.filing_status_hoh? in the method perhaps
There was a problem hiding this comment.
yeah we had a hoh qualifiying dependent on a single filer
arinchoi03
approved these changes
Jan 29, 2025
tahsinaislam
deleted the
FYST-1721-az-do-not-include-qual-child-dependent-name-unless-filer-is-ho-h
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-1721
Is PM acceptance required? (delete one)
What was done?
How to test?