Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR comments and cleanup #5461

Merged
merged 1 commit into from
Jan 30, 2025
Merged

PR comments and cleanup #5461

merged 1 commit into from
Jan 30, 2025

Conversation

mmazanec22
Copy link
Contributor

Link to pivotal/JIRA issue

Fast follow for #5455

Is PM acceptance required? (delete one)

  • No - merge after code review approval

What was done?

Address PR comments, clean up

How to test?

Make sure tests don't fail

Copy link

Heroku app: https://gyr-review-app-5461-6622d3950b2f.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5461 (optionally add --tail)

Copy link
Contributor

@jenny-heath jenny-heath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@mmazanec22 mmazanec22 merged commit a256175 into main Jan 30, 2025
7 checks passed
@mmazanec22 mmazanec22 deleted the nj-275-employer-name-ff branch January 30, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants