Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page 1 certified volunteer section dependents 13614c #5453

Conversation

embarnard
Copy link
Contributor

@embarnard embarnard commented Jan 27, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Add PDF mapping for the dependents and certified volunteer section of the 13614c form on Page 1

How to test?

  • Add dependents with certified volunteer info on the hub and check if it generates onto the pdf under client docs

Screenshots (for visual changes)

Screenshot 2025-01-27 at 2 51 47 PM

Copy link

Heroku app: https://gyr-review-app-5453-ba796e9e5486.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5453 (optionally add --tail)

@@ -608,8 +648,8 @@
expect(intake_pdf.hash_for_pdf[additional_comments_key]).to eq(<<~COMMENT.strip)
Other income types: garden gnoming
Additional Dependents:
(a) Polly Pony (b) 8/27/2018 (c) Baby (d) 5 (e) N (f) Y (g) S (h) N (i) Y CVP: ////
(a) Patrick Pony (b) 3/11/2019 (c) Son (d) 8 (e) N (f) Y (g) S (h) N (i) N CVP: ////
(a) Polly Pony (b) 8/27/2018 (c) Baby (d) 5 (e) S (f) N (g) Y (h) N (i) Y CVP: ////
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@spompea-cfa spompea-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

…-1-make-sure-collected-fields-in-the-editable-13614-c-populates-the-pdf-form-in-the-correct-places
…-1-make-sure-collected-fields-in-the-editable-13614-c-populates-the-pdf-form-in-the-correct-places
@embarnard embarnard merged commit b636d8e into main Jan 28, 2025
7 checks passed
@embarnard embarnard deleted the GYR1-627-mapping-page-1-make-sure-collected-fields-in-the-editable-13614-c-populates-the-pdf-form-in-the-correct-places branch January 28, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants