Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't poll for efile submission acks/status on sunday #5452

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

mrotondo
Copy link
Contributor

@mrotondo mrotondo commented Jan 27, 2025

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Change our crontab to exclude sundays from the schedule for polling MeF for acks & status of our submissions, since it's always down on sunday

How to test?

  • We should see this change's effect by observing a lack of errors on sentry on sundays - i.e. the above-linked sentry error should not have a large number of new occurrences on sundays after this PR is merged & released

Copy link

Heroku app: https://gyr-review-app-5452-6b2f4e0fe228.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5452 (optionally add --tail)

Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 yay! not familiar with the syntax but double checked using this

https://crontab.guru/#*/10_*_*_*_1-6

@mrotondo mrotondo merged commit 03cb62c into main Jan 27, 2025
7 checks passed
@mrotondo mrotondo deleted the dont-poll-for-acks-on-sunday branch January 27, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants