GYR1-622 PAGE 3 Make sure all editable 13614-C fields populate into PDF correctly #5450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-5450-ca8741feeeff.herokuapp.com/ |
spompea-cfa
changed the title
powersurge360
approved these changes
Jan 27, 2025
app/lib/pdf_filler/f13614c_pdf.rb
Outdated
| yes_no_checkboxes("form1[0].page2[0].Part4[0].q7ExpensesRelatedTo[0]", @intake.paid_self_employment_expenses, include_unsure: true), | ||
| yes_no_checkboxes("form1[0].page2[0].Part5[0].q3AdoptAChild[0]", fetch_gated_value(@intake, :adopted_child), include_unsure: true), | ||
| # page 3 rhs section 1 of 3 | ||
| 'form1[0].page3[0].stndardItemizedDeductions[0].form1098[0]' => bool_checkbox(@intake.cv_1098_cb == YES), |
There was a problem hiding this comment.
You may consider enum_prop_yes? because it is generated and tied to database values. If, say, the literal value of yes changes in the database, this will begin to fail. Also, if the enum key changes, this will fail here, but the method will begin throwing an exception to alert us that the key has changed.
There was a problem hiding this comment.
that's a really good point. i've updated the code per your suggestion!
spompea-cfa
force-pushed
the
gyr1-622-page-3-all-mappings-incl-grays
branch
from
459dc36 to
c08c0f8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to Jira issue
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
For page 3, LHS ...
For page 3, RHS (gray questions) of the PDF ...
checked off on the PDF, and that fields are empty.
PDF, including the three distinct "Notes/Comments" fields on the right edge.
question (near the middle of the page) work correctly on the PDF.
Example