-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TBE-138 Deployment process automation #5447
base: main
Are you sure you want to change the base?
Conversation
- use Tax-Bot instead of GYR-deploy-alert - add notifications for release results - update version to fix broken images in the template - also added new tax-bot context in our circleci account
Heroku app: https://gyr-review-app-5447-06935c910009.herokuapp.com/ |
# Conflicts: # config/application.rb
This reverts commit 845ade1.
972228c
to
e949668
Compare
.github/release.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not tied to this template, I just like that dependabot commits get separated. i'm open to changes
- name: Generate release notes | ||
if: github.event.inputs.environment == 'prod' | ||
run: | | ||
release_command="gh release create ${{ env.NEW_VERSION }} --target ${GITHUB_SHA} --generate-notes --draft" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here the release notes are initially created as a draft
. It is my hope to automate publishing it once the job succeeds in circleci, but if that proves too challenging then it might be best to publish from the start rather than require a manual follow up step.
Link to pivotal/JIRA issue
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
#tax-alert
#tax-eng
How to test?
testing notifications:
fake-main-for-testing
testing github action to deploy:
workflow_dispatch
(aka manual trigger) until the config is on mainon.push
tofake-main-for-testing
to trigger the action to deploy to stagingScreenshots (for visual changes)
Test failures in #tax-alerts
Before
After
NEW: Deployment success in #tax-eng (Failed deployment not caputured)