Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBE-138 Deployment process automation #5447

Open
wants to merge 24 commits into
base: main
Choose a base branch
from

Conversation

mpidcock
Copy link
Member

@mpidcock mpidcock commented Jan 25, 2025

Link to pivotal/JIRA issue

Is PM acceptance required?

  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Use TaxBot instead of GYR-deploy-alert for exiting failed test notifications in #tax-alert
  • Add notifications for production deployment outcomes in #tax-eng
  • Update slack orb version to fix broken images in the template
  • Create a GitHub deployment action to replace the release script
    • Creates deployment articfacts that

How to test?

testing notifications:

  • push a commit with broken tests to fake-main-for-testing
  • merged to staging and tested deployments

testing github action to deploy:

  • can't use workflow_dispatch (aka manual trigger) until the config is on main
  • in the interim, used on.push to fake-main-for-testing to trigger the action to deploy to staging
  • full testing will have to continue after merge
  • (the release script will also continue to work)

Screenshots (for visual changes)

Test failures in #tax-alerts

Before
image
After
image

NEW: Deployment success in #tax-eng (Failed deployment not caputured)

image image

mrotondo and others added 3 commits January 21, 2025 15:06
- use Tax-Bot instead of GYR-deploy-alert
- add notifications for release results
- update version to fix broken images in the template
- also added new tax-bot context in our circleci account
Copy link

Heroku app: https://gyr-review-app-5447-06935c910009.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5447 (optionally add --tail)

@mpidcock mpidcock changed the title Update circleci slack notifications TBE-000 Update circleci slack notifications Jan 30, 2025
@mpidcock mpidcock changed the title TBE-000 Update circleci slack notifications Update circleci slack notifications Jan 30, 2025
@mpidcock mpidcock changed the title Update circleci slack notifications TBE-138 Deployment process automation Jan 31, 2025
@mpidcock mpidcock force-pushed the update-circleci-slack-alerts branch from 972228c to e949668 Compare January 31, 2025 02:15
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not tied to this template, I just like that dependabot commits get separated. i'm open to changes

- name: Generate release notes
if: github.event.inputs.environment == 'prod'
run: |
release_command="gh release create ${{ env.NEW_VERSION }} --target ${GITHUB_SHA} --generate-notes --draft"
Copy link
Member Author

@mpidcock mpidcock Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here the release notes are initially created as a draft. It is my hope to automate publishing it once the job succeeds in circleci, but if that proves too challenging then it might be best to publish from the start rather than require a manual follow up step.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants