Do not attempt to fill out account holder names if taxes are owed (ac…

[arinchoi03]

Link to pivotal/JIRA issue

• https://codeforamerica.atlassian.net/browse/FYST-1695

Is PM acceptance required? (delete one)

• Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

• For the 502xml, NameOnBankAccount is only filled out if: if @intake.payment_or_deposit_type.to_sym == :direct_deposit && @intake.refund_or_owe_taxes_type == :refund
• this logic was not duplicated for the filling out of the PDF:
  • See code:

   def full_names_of_bank_account_holders
        intake = @submission.data_source
        return nil unless intake.payment_or_deposit_type.to_sym == :direct_deposit
  

How to test?

• Describe the testing approach taken to verify the changes, including:
  • added a test to catch this bug
  • manually loaded a owed MD intake and loaded up the pdf
  • Use Nellie, choose direct_deposit at the taxes-owed controller, and hit download state return
  • confirmed in demo this was an error; confirmed on heroku that this no longer occurs

[arinchoi03]

guarding in case the NameOnBankAccount is for some reason nil when we actually do expect it so it doesn't crash

[github-actions]

Heroku app: https://gyr-review-app-5443-b6462cba189a.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5443 (optionally add --tail)

[mrotondo]

Nice catch!