Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct mappings for PDF filer info page #5441

Merged
merged 4 commits into from
Jan 24, 2025

Conversation

powersurge360
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Moved to yes / not yes
  • New method introduced to break up questions for more readability #with_prefix. Hopefully will open the door to better testing.

How to test?

  • Navigate through flows and make sure pdf populates correctly.

Screenshots (for visual changes)

  • Before
  • After
image

Copy link

Heroku app: https://gyr-review-app-5441-587dda536621.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5441 (optionally add --tail)

Copy link
Contributor

@spompea-cfa spompea-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@powersurge360 powersurge360 merged commit 3910e87 into main Jan 24, 2025
7 checks passed
@powersurge360 powersurge360 deleted the GYR1-599/correct-mapping-filer-pdf branch January 24, 2025 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants