[FYST-1697] update StateInformationService to be locale aware #5440
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
FYST-1697
Is PM acceptance required? (delete one)
What was done?
instead of the StateInformationService knowing a state's name and taxation department, it now knows where to find the name and taxation department in our locale files. this lets us easily localize those proper nouns (if/when we want to) the same way we manage all other localized content. this is similar to the 'sin' value in the StateInformationService; it's not the software identifier itself, rather it's where to find it.
Slack threads with more context
How to test?
state_name
parameter.Screenshots (for visual changes)
Before
After