Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix landing page content bugs #5407

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Fix landing page content bugs #5407

merged 1 commit into from
Jan 24, 2025

Conversation

mmazanec22
Copy link
Contributor

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/261

Is PM acceptance required? (delete one)

  • No - merge after code review approval

What was done?

Add built_with_html to NJ so that we can remove the "state of" text. Add a link to the help text html.

How to test?

Go to the NJ landing page and check for removal of text and addition of link. Go to the other landing pages and make sure they're not broken.

Screenshots (for visual changes)

  • Before
    image
  • After
    image

Copy link

Heroku app: https://gyr-review-app-5407-62002d892b1d.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5407 (optionally add --tail)

@mmazanec22 mmazanec22 force-pushed the nj-261-landing-content branch from f62b126 to b911547 Compare January 23, 2025 19:14
Copy link
Contributor

@powersurge360 powersurge360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@powersurge360
Copy link
Contributor

Missed there's a conflict. Looks good aside from that 😅

@mmazanec22 mmazanec22 force-pushed the nj-261-landing-content branch from b911547 to 4169db1 Compare January 24, 2025 14:00
@mmazanec22 mmazanec22 merged commit 504f659 into main Jan 24, 2025
7 checks passed
@mmazanec22 mmazanec22 deleted the nj-261-landing-content branch January 24, 2025 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants