Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FYST-1603 updates to NY intake flow #5404

Merged
merged 8 commits into from
Jan 23, 2025

Conversation

jenny-heath
Copy link
Contributor

@jenny-heath jenny-heath commented Jan 22, 2025

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Remove get started button on landing page for NY and display some copy about not supporting it anymore
  • Redirect from NY intake pages to landing page
    • note about this: it's already the case that pages in the intake flow require an intake in the session, so the only real purpose of redirecting is for the edge case where a client logs in using an existing NY intake and tries to manually visit the pages. this seems fairly unlikely but also it's fine to implement it temporarily until we delete more NY code?
    • update to this note: i only just realized that we won't have any ny intakes to log in with because we deleted them :( so maybe it was all for naught
    • another update: we're now just skipping the tests for ny controllers

How to test?

  • Added a feature spec

Screenshots (for visual changes)

  • Before
image
  • After
image image

Copy link

Heroku app: https://gyr-review-app-5404-896184ec15d8.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5404 (optionally add --tail)

jenny-heath and others added 2 commits January 22, 2025 14:44
@jenny-heath jenny-heath marked this pull request as ready for review January 22, 2025 23:18
jenny-heath and others added 3 commits January 22, 2025 16:43
Co-authored-by: Anisha Ramnani <aramnani@codeforamerica.org>
…emove some unused methods

Co-authored-by: Anisha Ramnani <aramnani@codeforamerica.org>
Co-authored-by: Anisha Ramnani <aramnani@codeforamerica.org>
Copy link
Contributor

@anisharamnani anisharamnani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

jenny and i paired on reviewing this. thanks jenny!

@jenny-heath jenny-heath merged commit b7947c1 into main Jan 23, 2025
4 checks passed
@jenny-heath jenny-heath deleted the FYST-1603-updates-to-ny-intake-flow branch January 23, 2025 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants