Fyst [1519&1518] add mailing address validation step to flow #5401
Conversation
…resses-selection-logic
DrewProebstel
changed the title
app/controllers/state_file/archived_intakes/mailing_address_validation_controller.rb
Show resolved
Hide resolved
app/controllers/state_file/archived_intakes/mailing_address_validation_controller.rb
Outdated
Show resolved
Hide resolved
spec/controllers/state_file/archived_intake/mailing_address_validation_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/state_file/archived_intake/mailing_address_validation_controller_spec.rb
Outdated
Show resolved
Hide resolved
spec/controllers/state_file/archived_intake/mailing_address_validation_controller_spec.rb
Show resolved
Hide resolved
spec/controllers/state_file/archived_intake/archived_intake_controller_spec.rb
Outdated
Show resolved
Hide resolved
|
👋 thanks for doing this work! sorting out how to make the fake addresses seems to be quite complicated! i've left a bunch of comments. let me know if its easier to pair and walk through them. |
…resses-selection-logic
|
Heroku app: https://gyr-review-app-5401-06e1edd79e30.herokuapp.com/ |
| end | ||
| end | ||
|
|
||
| def download_file_from_s3(bucket, file_key, file_path) |
There was a problem hiding this comment.
this is the line you're referring to?
i once again must be misunderstanding how do you choose NY or AZ
There was a problem hiding this comment.
it's now line 55: "#{state_file_archived_intake.mailing_state.downcase}_addresses.csv"
| def create_state_file_access_log(event_type) | ||
| StateFileArchivedIntakeAccessLog.create!( | ||
| event_type: event_type, | ||
| state_file_archived_intake_request: current_request | ||
| ) | ||
| end | ||
|
|
||
| def address_challenge_set |
There was a problem hiding this comment.
why is the address_challenge_set defined here? are we trying to hide the method?
🤔 if that's the case, since it's not shared across controllers, how do you feel about putting it at the model level?
| end | ||
| end | ||
|
|
||
| context "without a chosen address" do |
There was a problem hiding this comment.
can you explain the case when this would happen where a post to update would occur & we wouldn't want to lock them out?
There was a problem hiding this comment.
handles the case where the user is hits submit without selecting an addresss
|
|
||
| access_log = StateFileArchivedIntakeAccessLog.last | ||
| expect(access_log.state_file_archived_intake_request).to eq(current_request) | ||
| expect(access_log.event_type).to eq("correct_mailing_address") |
There was a problem hiding this comment.
can you add a test verifying that the session data has been updated?
There was a problem hiding this comment.
thanks @DrewProebstel! this is a monster of a PR, and therefore a difficult challenge. thank you for handling this!
DrewProebstel
deleted the
FYST-1519-create-library-of-random-az-ny-addresses-selection-logic
branch
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
get_your_pdfflipper tag is enabled and that a statefile archived intake from the seeder file is used the go though the get your pdf flow til this page is hit.Screenshots (for visual changes)