Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyr1 601/map income pdf #5394

Merged
merged 17 commits into from
Jan 28, 2025
Merged

Gyr1 601/map income pdf #5394

merged 17 commits into from
Jan 28, 2025

Conversation

powersurge360
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Adds income left hand fields.

How to test?

  • Navigate through the flow, ticking the income related boxes
  • Navigate to the client and PDF in the hub

Screenshots (for visual changes)

  • Before
  • After
image

@powersurge360 powersurge360 reopened this Jan 21, 2025
Copy link

Heroku app: https://gyr-review-app-5394-b91f3c7426ec.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5394 (optionally add --tail)

Copy link

Heroku app: https://gyr-review-app-5394-f602185b9f0b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5394 (optionally add --tail)

spompea-cfa
spompea-cfa previously approved these changes Jan 23, 2025
Copy link
Contributor

@spompea-cfa spompea-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

@spompea-cfa spompea-cfa dismissed their stale review January 24, 2025 03:31

will re-review! =)

Copy link
Contributor

@spompea-cfa spompea-cfa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved 🎉

@powersurge360 powersurge360 merged commit 1b13e80 into main Jan 28, 2025
7 checks passed
@powersurge360 powersurge360 deleted the GYR1-601/map-income-pdf branch January 28, 2025 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants