Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYST-1270 Tax period not included in return header for NC #5083

Merged
merged 1 commit into from
Dec 4, 2024
Merged

FYST-1270 Tax period not included in return header for NC #5083

merged 1 commit into from
Dec 4, 2024

Conversation

tahsinaislam
Copy link
Contributor

@tahsinaislam tahsinaislam commented Dec 3, 2024 •
edited
Loading

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-1270

Is PM acceptance required?

  • Yes - don't merge until JIRA issue is accepted!

What was done?

  • Added a method on intakes on whether return header tax period begin and end date is to be shown
  • Fixed d400 pdf so that it is not looking for tax period in the return head but rather from the intake

How to test?

  • Unit test was edited and a new one was added for the return header spec

Screenshots (for visual changes)

  • Before
Screenshot 2024-12-03 at 3 55 47 PM
  • After
Screenshot 2024-12-03 at 3 56 25 PM

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

Heroku app: https://gyr-review-app-5083-e83b949540bb.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5083 (optionally add --tail)

@tahsinaislam tahsinaislam marked this pull request as ready for review December 3, 2024 23:57
arinchoi03
arinchoi03 approved these changes Dec 4, 2024
View reviewed changes
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good to me but I wish there was more in the story about why NC doesn't want these dates in their xml?

@tahsinaislam tahsinaislam merged commit 00042fc into main Dec 4, 2024
7 checks passed
@tahsinaislam tahsinaislam deleted the FYST-1270-do-not-send-tax-period-begin-dt-and-tax-period-end-dt-for-nc branch December 4, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tahsinaislam @arinchoi03