Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fyst-1224] nc screener flow #5052

Merged
merged 10 commits into from
Dec 3, 2024
Merged

[Fyst-1224] nc screener flow #5052

merged 10 commits into from
Dec 3, 2024

Conversation

squanto
Copy link
Contributor

@squanto squanto commented Dec 2, 2024

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • add new columns + update eligibility rules for nc intakes
  • Update form to just show new question the be valid

How to test?

  • Start NC flow
  • Verify eligiblity requirements

Screenshots (for visual changes)

Screenshot 2024-12-02 at 11 29 02 AM

Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Copy link

github-actions bot commented Dec 2, 2024

Heroku app: https://gyr-review-app-5052-7c63a755211b.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5052 (optionally add --tail)

Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Copy link
Contributor

@tahsinaislam tahsinaislam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
@squanto squanto changed the title Fyst 1224 nc screener flow [Fyst-1224] nc screener flow Dec 3, 2024
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
Co-authored-by: Hugo Melo <hmelo@codeforamerica.org>
@squanto squanto merged commit 78da193 into main Dec 3, 2024
7 checks passed
@squanto squanto deleted the FYST-1224-nc-screener-flow branch December 3, 2024 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants