Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NJ 157 - add review screen for dependents attending college #5025

Merged
merged 1 commit into from
Nov 25, 2024

Conversation

aloverso
Copy link
Contributor

Link to pivotal/JIRA issue

https://github.com/newjersey/affordability-pm/issues/157

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

What was done?

Fast-follow for college dependents work that was merged, add to review screen

How to test?

  • Use zeus_many_deps and select some but not all of them with all four checkboxes to see only the qualified dependents listed in review
  • Use zeus_many_deps and no dependents fully to see the "None" state on review
  • Use minimal to see that the section does not appear in review when no dependents under 22

Screenshots (for visual changes)

image

Copy link

Heroku app: https://gyr-review-app-5025-d3c921f16dbd.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5025 (optionally add --tail)

Copy link
Contributor

@mmazanec22 mmazanec22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, follows the pattern, yay

Copy link
Contributor

@mrotondo mrotondo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@aloverso aloverso merged commit 61c5736 into main Nov 25, 2024
7 checks passed
@aloverso aloverso deleted the nj-157-college-deps-review-page branch November 25, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants