Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add income review card to final review screen #5006

Merged
merged 2 commits into from
Nov 20, 2024
Merged

add income review card to final review screen #5006

merged 2 commits into from
Nov 20, 2024

Conversation

mrotondo
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Added a new card to the review header, which will show up for all states.
  • Note that this is not correct for NY, since the income review page was never added to the NY Question Navigation (flow), but I'm not addressing that since we aren't planning to ship with NY

How to test?

  • Go through the full flow for each state, and verify that the income details review card shows up, has an edit button that leads back to the income review page, and that clicking continue from that page leads back to the final review page

Screenshots (for visual changes)

image

@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-5006-200cc874c7d5.herokuapp.com/
View logs: heroku logs --app gyr-review-app-5006 (optionally add --tail)

arinchoi03
arinchoi03 approved these changes Nov 19, 2024
View reviewed changes
Copy link
Contributor

@arinchoi03 arinchoi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one suggestion but code looks good

app/controllers/state_file/questions/income_review_controller.rb
@@ -1,6 +1,7 @@
module StateFile
module Questions
class IncomeReviewController < QuestionsController
include ReturnToReviewConcern
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me -- can we add the spec to test it_behaves_like :return_to_review_concern?

@mrotondo mrotondo merged commit 6ab629b into main Nov 20, 2024
7 checks passed
@mrotondo mrotondo deleted the FYST-1084-add-income-review-card-to-final-review-screen branch November 20, 2024 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mrotondo @arinchoi03