Correct blinking disabled for nested question-with-follow-up #4988
Conversation
|
Heroku app: https://gyr-review-app-4988-0fc0c3f2ddd0.herokuapp.com/ |
| $container.find('.question-with-follow-up__follow-up input, .question-with-follow-up__follow-up select').attr('disabled', true); | ||
| $container.find('.question-with-follow-up__follow-up').hide(); | ||
| $container.find('> .question-with-follow-up__follow-up input, .question-with-follow-up__follow-up select').attr('disabled', true); | ||
| $container.find('> .question-with-follow-up__follow-up').hide(); |
There was a problem hiding this comment.
just a note that this used to exist in the previous followup implementation but it was removed in this PR codeforamerica/honeycrisp-gem#312 for honeycrisp gem -- we might not have any instances of followup questions after none of the above checkboxes
There was a problem hiding this comment.
I'm not sure I see the direct descendent selector in that diff?
There was a problem hiding this comment.
Oops wrong one -- I'll post the right one after lunch
There was a problem hiding this comment.
I was mistaken- it seemed like we solved for this case a long time ago and it was a tax-specific code addition to honeycrisp.js that was never implemented in the gem, so when I copied over the recent version we lost the existing fix -- which makes me feel a lot better about this as this is more like a return to status quo
|
Mike noted that even though the UX is correct, the form fields in nested attributes may still be active. Users will have to go out of their way to get to that funky functionality but it is possible. A full refactor of the JS for follow up questions (and perhaps even some changes into the structure of the HTML) is likely to solve all sharp edges. |
|
@powersurge360 can we document how we might get into that funky state & create a ticket/issue? cc @aloverso on the input blinking issue |
powersurge360
deleted the
FYST-1174/correct-nested-question-with-follow-up
branch
|
Link to pivotal/JIRA issue
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
yesonnc-sales-use-taxpage