Fyst 794 id permanent building fund tax #4946
Conversation
…o add a node for `nil` setter
| write_df_xml_value(__method__, "X") | ||
| def set_spouse_blind | ||
| create_or_destroy_df_xml_node(:spouse_blind, true, 'VirtualCurAcquiredDurTYInd') | ||
| write_df_xml_value(:spouse_blind, 'X') |
There was a problem hiding this comment.
refactored here because the primary_blind and spouse_blind xml readers were being overridden by the custom setters. Now these methods are more clear about their purpose and also allows us to easily access the value in the is_primary_blind? and is_spouse_blind? methods
We have to use :primary_blind & :spouse_blind keys instead of __method__ here because the method name doesn't match the key names of the selectors we're using to access the XML data.
There was a problem hiding this comment.
@jachan the refactor promised -- pls let me know if you have concerns. Unfortunately the implementation is split between multiple commits :( but if you just look at the changes in this file (and maybe the nj intakes factory) you should be caught up!
| context "has filing requirement, no blind filer, and no public assistance indicator" do | ||
| before do | ||
| intake.direct_file_data.total_income_amount = 40000 | ||
| intake.direct_file_data.total_itemized_or_standard_deduction_amount = 2112 |
There was a problem hiding this comment.
ooh how come we didn't use the no_filing_requirement / filing_requirement trait in the factory for these?
| context "when the client has filing requirement and is not blind" do | ||
| before do | ||
| intake.direct_file_data.total_income_amount = 40000 | ||
| intake.direct_file_data.total_itemized_or_standard_deduction_amount = 2112 |
There was a problem hiding this comment.
let's use the new traits here!
| <div id="permanent-building-fund" class="white-group"> | ||
| <div class="spacing-below-5"> | ||
| <p class="text--bold spacing-below-5"><%=t(".permanent_building_fund_tax") %></p> | ||
| <p><%= current_intake.received_id_public_assistance == "no" ? t("general.affirmative") : t("general.negative") %></p> |
There was a problem hiding this comment.
can we use the current_intake.received_id_public_assistance_no? here instead of the comparison
|
Heroku app: https://gyr-review-app-4946-58f939bde601.herokuapp.com/ |
https://codeforamerica.atlassian.net/browse/FYST-794
Is PM acceptance required? (delete one)
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)