Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove age method from person class and replace references in calculate_md502_cr_part_m_line_1 #4921

Conversation

embarnard
Copy link
Contributor

Link to pivotal/JIRA issue

Is PM acceptance required? (delete one)

  • No - merge after code review approval

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • We changed how we calculate DOB in this story; this age method does not reflect the differences in guidelines across states and should be removed and references instead should use the calculate_age method or other methods that ultimately use it

How to test?

  • should function the same, current tests for this method still pass

Copy link

Heroku app: https://gyr-review-app-4921-27899f0b120e.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4921 (optionally add --tail)

Copy link
Contributor

@powersurge360 powersurge360 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to look up the XOR operator cause I forgot but looks good!

@embarnard embarnard merged commit 6b69f76 into main Oct 29, 2024
7 checks passed
@embarnard embarnard deleted the FYST-1040-fix-age-calculations-for-calculate-md-502-cr-part-m-line-1 branch October 29, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants