FYST-788 Add interest income from obligations of the us #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Heroku app: https://gyr-review-app-4914-647421ccee45.herokuapp.com/ |
arinchoi03
approved these changes
Oct 28, 2024
| def calculate_sec_b_line_3 | ||
| sum = 0 | ||
| @direct_file_json_data.interest_reports.each do |interest_report| | ||
| sum += interest_report.interest_on_government_bonds |
There was a problem hiding this comment.
note to self: this will be 0 if the value was nil in the JSON, due to the DfJsonWrapper reader method, so we don't have to protect against a potential nil value 🙌
| "middleInitial": "T", | ||
| "lastName": "Interest", | ||
| "dateOfBirth": "1980-01-01", | ||
| "isPrimaryFiler": true |
There was a problem hiding this comment.
can the filer also have a tin field as well since that's something we should always expect (hopefully) from IRS?
There was a problem hiding this comment.
thanks i'll add in the tin values!
tahsinaislam
deleted the
FYST-788-interest-income-from-obligations-of-the-us
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to pivotal/JIRA issue
https://codeforamerica.atlassian.net/browse/FYST-788
Is PM acceptance required?
Reminder: merge main into this branch and get green tests before merging to main
What was done?
How to test?
Screenshots (for visual changes)