[FYST-992] adds a card to the income review page for SSA-1099 #4891
Conversation
| @@ -27,5 +27,14 @@ | |||
| </div> | |||
| <% end %> | |||
|
|
|||
| <% if current_intake.direct_file_data.fed_ssb > 0 || current_intake.direct_file_data.fed_taxable_ssb > 0 %> | |||
| <div class="white-group"> | |||
| <p class="text--bold spacing-below-0"><%= t(".ssa_title") %></p> | |||
There was a problem hiding this comment.
i'm following the markup structure from the card above, but semantically i think this should be an h2 or h3 rather than a p.
There was a problem hiding this comment.
[dust] low key agree but no strong opinion
| @@ -264,6 +264,11 @@ ul.with-bullets { | |||
| color: $color-red; | |||
| } | |||
|
|
|||
| .text--grey-bold { | |||
There was a problem hiding this comment.
is there an existing class for this somewhere? i did a brief search but didn't find one.
There was a problem hiding this comment.
[dust] it's my preference to not use red / grey / bold in these labels on the income review page, but I'm not feeling creative right now so idk what good names would be
There was a problem hiding this comment.
i have very strong opinions about this, but it's not the right time to open that particular can of worms.
|
Heroku app: https://gyr-review-app-4891-07f02e897a0a.herokuapp.com/ |
jnf
removed
the
wip
| @@ -264,6 +264,11 @@ ul.with-bullets { | |||
| color: $color-red; | |||
| } | |||
|
|
|||
| .text--grey-bold { | |||
There was a problem hiding this comment.
[dust] it's my preference to not use red / grey / bold in these labels on the income review page, but I'm not feeling creative right now so idk what good names would be
| @@ -27,5 +27,14 @@ | |||
| </div> | |||
| <% end %> | |||
|
|
|||
| <% if current_intake.direct_file_data.fed_ssb > 0 || current_intake.direct_file_data.fed_taxable_ssb > 0 %> | |||
| <div class="white-group"> | |||
| <p class="text--bold spacing-below-0"><%= t(".ssa_title") %></p> | |||
There was a problem hiding this comment.
[dust] low key agree but no strong opinion
Link to pivotal/JIRA issue
FYST-992
Is PM acceptance required? (delete one)
Yes! - don't merge until JIRA issue is accepted!
Reminder: merge main into this branch and get green tests before merging to main
What was done?
SocSecBnftAmtorTaxableSocSecAmton the filer's 1040, the card is rendered. Otherwise it isn't.How to test?
Screenshots (for visual changes)
Before
After