Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FYST-787 Idaho screeners #4884

Merged
merged 27 commits into from
Oct 24, 2024
Merged

FYST-787 Idaho screeners #4884

merged 27 commits into from
Oct 24, 2024

Conversation

DrewProebstel
Copy link
Contributor

@DrewProebstel DrewProebstel commented Oct 17, 2024 •
edited
Loading

Link to pivotal/JIRA issue

https://codeforamerica.atlassian.net/browse/FYST-787

Is PM acceptance required? (delete one)

  • Yes - don't merge until JIRA issue is accepted!

Reminder: merge main into this branch and get green tests before merging to main

What was done?

  • Screener Question were added to the Idaho Flow of FYST
  • eligibility_lived_in_state and eligibility_out_of_state_income were pulled from the state_file_base_intake as they did not belong on the Idaho State File Intake.

How to test?

  • Describe the testing approach taken to verify the changes, including:
    • Tests were written for the new controller and new form
    • Idaho FYST feature test was updated with new screener content
  • Risk Assessment
    • Opposite of DRY on some of state file intakes, could increase complexity.

Screenshots (for visual changes)

  • After
image

Screenshot 2024-10-17 at 3 24 06 PM

Screenshot 2024-10-17 at 3 26 23 PM

Drew Proebstel and others added 10 commits October 15, 2024 11:25
migrations
ff528e8
functional
5fee5a1
functional
6f964e1
make text smaller
f9c0783
adds idaho screeners
f24b003
merge conflicts
cac9c4c
# This is a combination of 4 commits.
0221a42 
# This is the 1st commit message:

migrations

# This is the commit message #2:

functional

# This is the commit message #3:

make text smaller

# This is the commit message #4:

adds idaho screeners
Merge branch '787' of github.com:codeforamerica/vita-min into 787
ae5ba2a
@DrewProebstel
Merge branch 'main' into 787
78e3582
add eligible page
bdc4284
@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4884-ff829aed6792.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4884 (optionally add --tail)

@DrewProebstel DrewProebstel changed the title 787 FYST-787 Idaho screeners Oct 18, 2024
@DrewProebstel DrewProebstel reopened this Oct 21, 2024
@DrewProebstel DrewProebstel reopened this Oct 21, 2024
@github-actions GitHub Actions
Copy link

Heroku app: https://gyr-review-app-4884-eacaee07e98e.herokuapp.com/
View logs: heroku logs --app gyr-review-app-4884 (optionally add --tail)

embarnard
embarnard approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@embarnard embarnard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just that one requested change, no need for re-review

app/lib/navigation/state_file_id_question_navigation.rb Outdated Show resolved Hide resolved
app/views/state_file/questions/eligible/_az_supported.html.erb
@@ -0,0 +1,6 @@
<ul class="list--bulleted">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice thanks for adding all of these!

@DrewProebstel DrewProebstel merged commit 332b066 into main Oct 24, 2024
7 checks passed
@DrewProebstel DrewProebstel deleted the 787 branch October 24, 2024 16:52
@DrewProebstel DrewProebstel restored the 787 branch October 24, 2024 16:56
DrewProebstel added a commit that referenced this pull request Oct 24, 2024
@DrewProebstel
Revert "FYST-787 Idaho screeners (#4884)"
9fe406c 
This reverts commit 332b066.
@DrewProebstel DrewProebstel mentioned this pull request Oct 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arinchoi03 arinchoi03 arinchoi03 left review comments

@embarnard embarnard embarnard approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DrewProebstel @arinchoi03 @embarnard @mrotondo