review comments pt 2

codeforamerica · Nov 22, 2024 · e6241d4 · e6241d4
1 parent 5108ebc
commit e6241d4
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/app/lib/efile/nj/nj1040_calculator.rb b/app/lib/efile/nj/nj1040_calculator.rb
@@ -316,7 +316,7 @@ def calculate_line_49
 
       def calculate_line_50
         difference = calculate_line_45 - calculate_line_49
-        difference.positive? ? difference : 0
+        [difference, 0].max
       end
 
       def calculate_line_51
@@ -325,7 +325,7 @@ def calculate_line_51
 
       def calculate_line_54
         sum = calculate_line_50 + calculate_line_51
-        sum.positive? ? sum : 0
+        [sum, 0].max
       end
 
       def calculate_line_56

diff --git a/app/lib/pdf_filler/nj1040_pdf.rb b/app/lib/pdf_filler/nj1040_pdf.rb
@@ -404,7 +404,7 @@ def hash_for_pdf
                                                  ]))
       end
 
-      # line 50
+      # line 54
       if @xml_document.at("TotalTaxAndPenalty").present?
         total_tax_and_penalty = @xml_document.at("TotalTaxAndPenalty").text.to_i
         answers.merge!(insert_digits_into_fields(total_tax_and_penalty, [