-
Notifications
You must be signed in to change notification settings - Fork 344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localize buttons #360
Localize buttons #360
Conversation
I think this looks great so far. Could you please do 3 more things:
expect(page).to have_link 'Services' with expect(page).to have_link t('admin.navigation.services')
Thanks! |
4bc578d
to
864c8a3
Compare
…ation and buttons in views and specs. Admin buttons are namespaced with "admin".
5052a2b
to
c60c448
Compare
I think I have addressed the three issues you raised. I also removed the calls to admin.navigation and replaced them with calls to admin.buttons in config/locales/en.yml because they were repeating the same text. I'm not sure if this is the way you want this done. Another option would be referencing one in the other. Please let me know how you'd like that structured and I'll add that change in my next pull request. Thanks for being patient with me on this. |
Thanks so much for doing this! At first glance, this looks perfect. |
@@ -19,4 +19,4 @@ | |||
permanently. | |||
.modal-footer | |||
%button.btn.btn-default{ 'data-dismiss' => 'modal' } Close |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should "Close" be localized here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, good catch!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also move that to a shared partial as the same code is used on other delete views.
Adds localizations for buttons and navigation links in all view files.