Localize buttons

[tannerj]

Adds localizations for buttons and navigation links in all view files.

[monfresh]

I think this looks great so far. Could you please do 3 more things:

• Remove the trailing whitespace in config/locales/en.yml
• Update the specs that check for the text you localized so that they verify the localization as opposed to the text itself. For example, in https://github.com/codeforamerica/ohana-api/blob/master/spec/features/admin/dashboard_spec.rb#L123, replace:

expect(page).to have_link 'Services'

with

expect(page).to have_link t('admin.navigation.services')

• When you're done, please squash your commits into one. Let me know if you need help doing that.

Thanks!

[tannerj]

I think I have addressed the three issues you raised. I also removed the calls to admin.navigation and replaced them with calls to admin.buttons in config/locales/en.yml because they were repeating the same text. I'm not sure if this is the way you want this done. Another option would be referencing one in the other. Please let me know how you'd like that structured and I'll add that change in my next pull request. Thanks for being patient with me on this.

[monfresh]

Thanks so much for doing this! At first glance, this looks perfect.

[md5]

Should "Close" be localized here?

[monfresh]

Yes, good catch!

[monfresh]

We should also move that to a shared partial as the same code is used on other delete views.