Scan macro identifiers in external scanner #15
Merged
+726,766
−719,817
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d-alonso
requested review from
a team,
ruifm,
daniel-otero and
inaki-amatria
and removed request for
a team and
daniel-otero
d-alonso
force-pushed
the
feature/macroIdentifiersInVarDecls
branch
from
84e41cd to
7ac095a
Compare
d-alonso
force-pushed
the
feature/macroIdentifiersInVarDecls
branch
from
7ac095a to
2de8450
Compare
inaki-amatria
approved these changes
Jun 27, 2025
d-alonso
force-pushed
the
feature/macroIdentifiersInVarDecls
branch
from
8caf37f to
4ccf497
Compare
d-alonso
force-pushed
the
feature/macroIdentifiersInVarDecls
branch
from
4ccf497 to
5a7fa76
Compare
d-alonso
merged commit 5a7fa76
into
base/MergeTreeSitterFortranAndSomeGrammarImprovements
1 check passed
Sorry if I gave that impression, but I found no such grammar (I didn't look much though). I did found examples of grammars being tweaked by environment variables, for example markdowns': https://github.com/tree-sitter-grammars/tree-sitter-markdown/blob/7462bb66ac7e90312082269007fac2772fe5efd1/common/common.js#L3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
and allow them specifically for type specifiers in variable declarations. "Macro identifiers" can be set through an environment variable that users of this grammar can set
This is a bit esoteric but allowing any identifier in that grammar rule makes conflicts that are impossible to untangle