Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📝🐛 Spell "notifications" w/o mistakes #492

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

📝🐛 Spell "notifications" w/o mistakes #492

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions codecov_cli/services/upload/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ def do_upload_logic(
except click.ClickException as exp:
if handle_no_reports_found:
logger.info(
"No coverage reports found. Triggering notificaions without uploading."
"No coverage reports found. Triggering notifications without uploading."
)
upload_completion_logic(
commit_sha=commit_sha,
Expand All @@ -93,7 +93,7 @@ def do_upload_logic(
error=None,
warnings=None,
status_code=200,
text="No coverage reports found. Triggering notificaions without uploading.",
text="No coverage reports found. Triggering notifications without uploading.",
)
else:
raise exp
Expand Down
4 changes: 2 additions & 2 deletions tests/services/upload/test_upload_service.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -390,14 +390,14 @@ def side_effect(*args, **kwargs):
assert out_bytes == [
(
"info",
"No coverage reports found. Triggering notificaions without uploading.",
"No coverage reports found. Triggering notifications without uploading.",
),
]
assert res == RequestResult(
error=None,
warnings=None,
status_code=200,
text="No coverage reports found. Triggering notificaions without uploading.",
text="No coverage reports found. Triggering notifications without uploading.",
)
mock_select_preparation_plugins.assert_called_with(
cli_config, ["first_plugin", "another", "forth"]
Expand Down