test: versionInfo
#1407
Merged
test: versionInfo
#1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcobiedermann
commented
May 1, 2024
| .intercept({ | ||
| path: `/${platform}/${version}`, | ||
| }) | ||
| .reply(404, 'MESSAGE'); |
There was a problem hiding this comment.
Any arbitrary message would work as the service returns XML, which can not be parsed by the .json() method
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1407 +/- ##
==========================================
+ Coverage 91.37% 93.20% +1.83%
==========================================
Files 4 5 +1
Lines 313 324 +11
Branches 86 85 -1
==========================================
+ Hits 286 302 +16
+ Misses 25 20 -5
Partials 2 2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
RMSPORTS1902
approved these changes
May 4, 2024
RMSPORTS1902
approved these changes
May 4, 2024
|
Some workflows are failing as they were not up to date on |
Add full test coverage resolving the `versionInfo`
thomasrockhu-codecov
force-pushed
the
feature/version-tests
branch
from
dc7520d
to
20724b9
Compare
thomasrockhu-codecov
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add full test coverage resolving the
versionInfo