Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split register "type" column #98

Merged
merged 17 commits into from
Sep 5, 2024
Merged

Conversation

angelina-momin
Copy link
Collaborator

@angelina-momin angelina-momin commented Aug 20, 2024

Solves issues:

  • #89 in splitting register "type" column to "type" and "venue"
  • #85 in changing all URLs to lower case (was going to create a separate PR for that but then I found it easier to implement the changes already since I was redoing a lot of the code in codecheck repo)

Related codecheck PR #55

Changes made:

  • Update register.csv by splitting the column "type" into "type" and "venue" where
    Venue = what is in brackets now
    Type = outside of brackets
  • The venues subfolders were all changed to lowercase
  • All featured.json, index.html, register.json and register.md files have been updated so that they now have a separate type and venue entry
  • The tables for each venue no longer have "Type" and "Venue" column as they are redudant
  • The number of codechecks was changed from string to int in all codecheckers, all venues and venues subcategories index.json files.
  • Update libs versions.

@nuest
Copy link
Member

nuest commented Aug 20, 2024

Is the rendering code already capable to handle this change?

@nuest
Copy link
Member

nuest commented Aug 20, 2024

Ups, sorry, I see the draft tag now.

@angelina-momin angelina-momin marked this pull request as ready for review August 22, 2024 12:32
@angelina-momin
Copy link
Collaborator Author

@nuest the PR is ready to be reviewed. Made some changes and updated the description of this PR to reflect that.

@nuest nuest merged commit f765680 into master Sep 5, 2024
@nuest nuest deleted the Split-register-type-into-type,-venue branch September 5, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants