Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a list of all checks for each venue type #50

Conversation

angelina-momin
Copy link
Collaborator

@angelina-momin angelina-momin commented Aug 15, 2024

Solves issue #93
Related PR in the register repo: #99

  • Added functionality to create list of all checks for each venue type.
  • Refactored functionalities
  • Bump version to 0.6.0

Screenshot 2024-08-15 at 13 11 16
Screenshot 2024-08-15 at 13 11 38
Screenshot 2024-08-15 at 13 11 44

@nuest nuest self-requested a review August 15, 2024 11:25
R/utils_render_reigster_html.r Outdated Show resolved Hide resolved
R/utils_render_table_non_registers.R Outdated Show resolved Hide resolved
@nuest
Copy link
Member

nuest commented Aug 15, 2024

@angelina-momin there seems to be a minor formatting issue or something similar, the checks are all failing. Please take a look! Otherwise happy if you merge this.

We should deactivate the MacOS checks at this opportunity, they are always failing and it's good enough to check on 2 OSs.

@angelina-momin
Copy link
Collaborator Author

Closing this PR because new replacement PR (created due to this PR's messy git history) has been merged

@angelina-momin angelina-momin deleted the create-page-list-venues-subcategories branch August 20, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants