Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to filter register by venue #40

Merged

Conversation

angelina-momin
Copy link
Collaborator

@angelina-momin angelina-momin commented May 13, 2024

Resolves issue #46

Related to changes in register: codecheckers/register#64

This PR has a lot of major changes. Ideally I would have liked fewer changes but I needed to refactor, rewrite a significant amount of code for this new feature. As a result I think the following PR's will be shorter as less will need to be refactored to put in changes.

The following changes were made:

  • Bumped version to 0.2.0
  • register.R and render utils functions now creates separate registries for each venue.
  • Created utils_register_sort.R. It has the utility function create_list_venue_sorted_register_tables
  • Removed add_repository_links from preprocessing to keep the links generic format. Instead the repository links are now added dynamically when rendering the md and html files. This way "register" will not need to be passed each time.
  • In R-CMD-check.yaml, configured GitHub Action R package build so that it throws error on error only and not with warnings.
  • As R does not have dynamic scoping, I added global config CONFIG in register.R to avoid defining too many arguments for each function. I will consider refactoring later on if I can find an alternative to using globals.

@angelina-momin angelina-momin marked this pull request as ready for review May 20, 2024 19:51
@angelina-momin
Copy link
Collaborator Author

angelina-momin commented May 22, 2024

Still need to fix issue regarding hrefs in the margin of the sorted registers' html files

@angelina-momin angelina-momin requested a review from nuest May 22, 2024 10:27
@angelina-momin angelina-momin changed the title Add feature to sort register by venue Add feature to filter register by venue May 29, 2024
@nuest
Copy link
Member

nuest commented Jun 18, 2024

@angelina-momin Good job!

@angelina-momin angelina-momin merged commit c9229fe into codecheckers:master Jun 19, 2024
4 checks passed
@angelina-momin angelina-momin deleted the feature-venue-sorted-register branch June 19, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants