-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature to filter register by venue #40
Merged
angelina-momin
merged 36 commits into
codecheckers:master
from
angelina-momin:feature-venue-sorted-register
Jun 19, 2024
Merged
Add feature to filter register by venue #40
angelina-momin
merged 36 commits into
codecheckers:master
from
angelina-momin:feature-venue-sorted-register
Jun 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Still need to fix issue regarding hrefs in the margin of the sorted registers' html files |
This was referenced May 27, 2024
angelina-momin
changed the title
Add feature to sort register by venue
Add feature to filter register by venue
May 29, 2024
nuest
approved these changes
Jun 18, 2024
@angelina-momin Good job! |
This was referenced Jun 19, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves issue #46
Related to changes in register: codecheckers/register#64
This PR has a lot of major changes. Ideally I would have liked fewer changes but I needed to refactor, rewrite a significant amount of code for this new feature. As a result I think the following PR's will be shorter as less will need to be refactored to put in changes.
The following changes were made:
0.2.0
register.R
and render utils functions now creates separate registries for each venue.utils_register_sort.R
. It has the utility functioncreate_list_venue_sorted_register_tables
add_repository_links
from preprocessing to keep the links generic format. Instead the repository links are now added dynamically when rendering the md and html files. This way "register" will not need to be passed each time.R-CMD-check.yaml
, configured GitHub Action R package build so that it throws error on error only and not with warnings.CONFIG
inregister.R
to avoid defining too many arguments for each function. I will consider refactoring later on if I can find an alternative to using globals.