-
-
Notifications
You must be signed in to change notification settings - Fork 729
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(webApi): error message of dontSeeCookie #4357
Conversation
I'm not sure if we should have this change. As the error message is from here already indicated not. Line 63 in 0e1b86a
|
Oh, I think I understand. |
@a-stankevich I saw you also mentioned WebDriver, but don't see the changes there. May you check? |
Those changes were done by mistake and have been reverted. I've unchecked related checkboxes now |
* fix(webApi): error message of dontSeeCookie (#4357) * Fixed error message for dontSeeCookie() * fix(cli): gherkin command init with TypeScript (#4366) * DOC: Update contributor faces * fix(doc): Expect helper is not described correctly (#4370) * fix: Puppeteer helper doc typo (#4369) * chore(deps): bump devtools from 8.36.1 to 8.38.0 (#4374) * chore(deps-dev): bump playwright from 1.44.0 to 1.44.1 (#4376) Bumps [playwright](https://github.com/microsoft/playwright) from 1.44.0 to 1.44.1. - [Release notes](https://github.com/microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.44.0...v1.44.1) --- updated-dependencies: - dependency-name: playwright dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore(deps): bump axios from 1.6.7 to 1.7.2 (#4372) * chore(deps-dev): bump typedoc-plugin-markdown from 3.17.1 to 4.0.3 (#4373) * fix: handle throw error inside retryTo promise * fix: test due to update on retryTo plugin * fix: add a test case succeed after 2 retry --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Arthur Stankevich <a-stankevich@users.noreply.github.com> Co-authored-by: Ando NARY <36852616+andonary@users.noreply.github.com> Co-authored-by: GitHub Action <action@github.com> Co-authored-by: KobeN <7845001+kobenguyent@users.noreply.github.com> Co-authored-by: Yoann Fleury <yoann.fleury@yahoo.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Motivation/Description of the PR
The error message reported for 'dontSeeCookie' was copy-pasted from 'seeCookie', while it should be the opposite.
The only helper with correct message is TestCafe, so wording from there is applied to other helpers.
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs
)npm run lint
)npm test
)