fix: disable retryFailedStep when using with tryTo (#4022)

codeceptjs · Nov 29, 2023 · 1936b0b · 1936b0b
1 parent d0901d8
commit 1936b0b
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 11 deletions.
diff --git a/lib/plugin/retryFailedStep.js b/lib/plugin/retryFailedStep.js
@@ -1,5 +1,6 @@
 const event = require('../event');
 const recorder = require('../recorder');
+const container = require('../container');
 
 const defaultConfig = {
   retries: 3,
@@ -98,6 +99,8 @@ module.exports = (config) => {
   config.when = when;
 
   event.dispatcher.on(event.step.started, (step) => {
+    if (container.plugins('tryTo')) return;
+
     // if a step is ignored - return
     for (const ignored of config.ignoredSteps) {
       if (step.name === ignored) return;

diff --git a/test/unit/plugin/retryFailedStep_test.js b/test/unit/plugin/retryFailedStep_test.js
@@ -28,7 +28,7 @@ describe('retryFailedStep', () => {
     event.dispatcher.emit(event.step.started, { name: 'click' });
 
     let counter = 0;
-    recorder.add(() => {
+    await recorder.add(() => {
       counter++;
       if (counter < 3) {
         throw new Error();
@@ -51,7 +51,7 @@ describe('retryFailedStep', () => {
       });
       await recorder.promise();
     } catch (e) {
-      recorder.catchWithoutStop((err) => err);
+      await recorder.catchWithoutStop((err) => err);
     }
 
     // expects to retry only once
@@ -65,15 +65,15 @@ describe('retryFailedStep', () => {
     let counter = 0;
     event.dispatcher.emit(event.step.started, { name: 'waitForElement' });
     try {
-      recorder.add(() => {
+      await recorder.add(() => {
         counter++;
         if (counter < 3) {
           throw new Error();
         }
       }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
-      recorder.catchWithoutStop((err) => err);
+      await recorder.catchWithoutStop((err) => err);
     }
 
     expect(counter).to.equal(1);
@@ -87,15 +87,15 @@ describe('retryFailedStep', () => {
     let counter = 0;
     event.dispatcher.emit(event.step.started, { name: 'amOnPage' });
     try {
-      recorder.add(() => {
+      await recorder.add(() => {
         counter++;
         if (counter < 3) {
           throw new Error();
         }
       }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
-      recorder.catchWithoutStop((err) => err);
+      await recorder.catchWithoutStop((err) => err);
     }
 
     expect(counter).to.equal(1);
@@ -109,15 +109,15 @@ describe('retryFailedStep', () => {
     let counter = 0;
     event.dispatcher.emit(event.step.started, { name: 'somethingNew' });
     try {
-      recorder.add(() => {
+      await recorder.add(() => {
         counter++;
         if (counter < 3) {
           throw new Error();
         }
       }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
-      recorder.catchWithoutStop((err) => err);
+      await recorder.catchWithoutStop((err) => err);
     }
 
     expect(counter).to.equal(1);
@@ -131,15 +131,15 @@ describe('retryFailedStep', () => {
     let counter = 0;
     event.dispatcher.emit(event.step.started, { name: 'somethingNew' });
     try {
-      recorder.add(() => {
+      await recorder.add(() => {
         counter++;
         if (counter < 3) {
           throw new Error();
         }
       }, undefined, undefined, true);
       await recorder.promise();
     } catch (e) {
-      recorder.catchWithoutStop((err) => err);
+      await recorder.catchWithoutStop((err) => err);
     }
 
     expect(counter).to.equal(1);
@@ -161,7 +161,7 @@ describe('retryFailedStep', () => {
       });
       await recorder.promise();
     } catch (e) {
-      recorder.catchWithoutStop((err) => err);
+      await recorder.catchWithoutStop((err) => err);
     }
 
     // expects to retry only once