Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi-bind on IsVisible to bypass a WPF leak issue #968

Merged
merged 1 commit into from
Jul 22, 2023
Merged

Multi-bind on IsVisible to bypass a WPF leak issue #968

merged 1 commit into from
Jul 22, 2023

Conversation

codecadwallader
Copy link
Owner

Proposed solution for #966

@codecadwallader codecadwallader mentioned this pull request Jan 14, 2023
Open
@ryanmolden
Copy link

The fix looks good, will that also fix RadialProgressBar? It looks like it just hit BuildProgressView.

@codecadwallader
Copy link
Owner Author

Thanks for taking a look, appreciated!

I don't see that we are using the IsIndeterminate property on the RadilProgressBar, only the BuildProgressView. Does it have to be set even if it's not being used and is always false?

@codecadwallader codecadwallader merged commit c25e452 into dev Jul 22, 2023
@codecadwallader codecadwallader deleted the progress-isindeterminate branch July 22, 2023 21:30
@codecadwallader codecadwallader linked an issue Jul 22, 2023 that may be closed by this pull request
BuildProgressView and RadialProgressBar leak WPF animations #966
Open
@codecadwallader codecadwallader added this to the v12.1 milestone Jul 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v12.1
Development

Successfully merging this pull request may close these issues.

BuildProgressView and RadialProgressBar leak WPF animations
2 participants
@codecadwallader @ryanmolden