Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify vsct by removing unnecessary guids #519

Merged
merged 1 commit into from
Jan 25, 2018

Conversation

heku
Copy link
Contributor

@heku heku commented Jan 23, 2018

Hi, before I pull a request for menu visibility, I'd like to pull this request for simplifying vsct.

@codecadwallader
Copy link
Owner

Thank you for the contribution. Can you explain why all those GUIDs were unnecessary and can all be identical?

@heku
Copy link
Contributor Author

heku commented Jan 24, 2018

Because VS identify an UI item (menu,button,group...) by both GUID and ID, so it's no need to give every individual UI item a GUID. For one package, it's better to define only one GUID for all UI item to avoid mess.

A good thing I found is all your ids are unique, so I just update the GUID part.

@codecadwallader
Copy link
Owner

Ok that makes sense, thanks for teaching me that. :) I had always assumed it needed to be unique per item but I checked a couple other popular repos and they also use a shared GUID.

@codecadwallader codecadwallader merged commit 6dce7c2 into codecadwallader:master Jan 25, 2018
@codecadwallader
Copy link
Owner

Merged! Thank you again for making this simplification. The VSCT approach for defining integration with the IDE is very verbose and any simplifications are definitely helpful. :)

@heku
Copy link
Contributor Author

heku commented Jan 25, 2018

You're welcome, your codemaid is a great work, I like it very much and I learned so much from your code as well.

@heku heku deleted the simplify branch March 25, 2018 06:48
@codecadwallader codecadwallader added this to the v10.5 milestone Apr 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants