The localization of Chinese has been completed #506

maikebing · 2017-12-19T07:03:53Z

Extract all strings and WPF strings that need to be translated And the use of TomEnglert.ResXManager for translation work, of which Chinese has been translated.

…e use of TomEnglert.ResXManager for translation work, of which Chinese has been translated.

maikebing · 2017-12-27T05:09:07Z

@codecadwallader do you have time merge it ?

codecadwallader · 2017-12-28T11:47:55Z

I wasn't sure if you were ready for review, I will look over it.

codecadwallader · 2017-12-28T11:50:05Z

CodeMaid/CodeMaid.csproj

    <EmbeddedResource Include="source.extension.resx">
      <AutoGen>True</AutoGen>
      <DesignTime>True</DesignTime>
      <DependentUpon>source.extension.vsixmanifest</DependentUpon>
      <MergeWithCTO>true</MergeWithCTO>
      <ManifestResourceName>VSPackage</ManifestResourceName>
    </EmbeddedResource>
+    <EmbeddedResource Include="source.extension.zh-Hans.resx">


I wasn't aware you could have a resources translation of the manifest file. How does this work?

Visual Studio compiles automatic local language using different manifest files

codecadwallader · 2017-12-28T11:51:46Z

CodeMaid/CodeMaid.vsct

@@ -288,13 +288,15 @@
          If you do not want an image next to your command, remove the Icon node or set it to <Icon guid="guidOfficeIcon" id="msotcidNoIcon" /> -->
      <Button guid="GuidCodeMaidCommandAbout" id="CmdIDCodeMaidAbout" priority="0x0100" type="Button">
        <Icon guid="GuidImageInfo" id="IconInfo" />
+        <CommandFlag>TextChanges</CommandFlag>


Making the text dynamic can hurt performance, since Visual Studio will re-evaluate it constantly. Does this have to be done, or is there another way to point the VSCT definitions directly to resource keys?

Except for the dynamic text, I didn't find a better way to do it.There seems to be an article that says VSCT can have multiple languages. But I don't know how to do it so far.

I think looking into this further will be necessary.. in the past the performance hit was debilitating as our extension as well as other ones would cause each other to infinitely regenerate the text.

I tried the method described in MSDN, but I didn't succeed and I didn't know what the problem was.
url: https://msdn.microsoft.com/en-us/library/ee943168.aspx

The MSDN approach has been successful ！
3642dec

codecadwallader · 2017-12-28T11:53:20Z

CodeMaid/Integration/Commands/CleanupAllCodeCommand.cs

@@ -48,12 +48,12 @@ protected override void OnExecute()

            if (!CodeCleanupAvailabilityLogic.IsCleanupEnvironmentAvailable())
            {
-                MessageBox.Show(@"Cleanup cannot run while debugging.",
-                                @"CodeMaid: Cleanup All Code",
+                MessageBox.Show(StringResourceKey.CleanupAllCodeCommand_OnExecute_CleanupCannotRunWhileDebugging,


Some of these key names are really long, compared to other ones which are much shorter. I'd prefer the shorter versions - I don't think the whole path of where every key came from is necessary.

I used tom-englert/ResXResourceManager to achieve string extraction, and I used the variable name that it automatically generated.In order to complete the extraction of string statements as soon as possible, I have no refactoring.

I would like to have these simplified before accepting the pull request.. otherwise the code will be pretty difficult to read.

Code has been refactored e279ed8

codecadwallader · 2017-12-28T11:57:21Z

CodeMaid/Integration/Commands/CommentFormatCommand.cs

@@ -27,7 +27,7 @@ internal CommentFormatCommand(CodeMaidPackage package)
            : base(package,
                   new CommandID(PackageGuids.GuidCodeMaidCommandCommentFormat, PackageIds.CmdIDCodeMaidCommentFormat))
        {
-            _undoTransactionHelper = new UndoTransactionHelper(package, "CodeMaid Format Comment");
+            _undoTransactionHelper = new UndoTransactionHelper(package, StringResourceKey.CommentFormatCommand_CommentFormatCommand_CodeMaidFormatComment);


Instead of StringResourceKey, you could access the Resources directly like you do in some cases below.

StringResourceKey is the name of the string resource class that is used by default when tom-englert/ResXResourceManager is automatically generated. It's not perfect, but it's the best localization translation tool I've ever met.

Sometimes StringResourceKey is used.. sometimes Resources is used. I think to avoid confusion Resources should always be used where possible.

Using resources requires referencing namespace SteveCadwallader.CodeMaid.Properties, but using Stringresourcekey does not require Stevecadwallader.codemaid, Because the root namespace is it. It would be awkward to add namespaces to all the required code SteveCadwallader.CodeMaid.Properties. However, it is easier to refer to SteveCadwallader.CodeMaid.Properties in WPF.

codecadwallader · 2017-12-28T11:59:08Z

CodeMaid/Properties/Resources.zh-Hans.resx

+    <value>System.Resources.ResXResourceWriter, System.Windows.Forms, Version=4.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089</value>
+  </resheader>
+  <data name="BuildProgressToolWindow_BuildProgress" xml:space="preserve">
+    <value>生成进度</value>


How were all of these translations done? Was it an automated tool, did you do them manually? Since I don't speak Chinese I am concerned if any of them may be offensive, confusing or misleading.

The first is through the use of Tom-englert/resxresourcemanager Microsoft translation, and then manual proofreading.， It conforms to the Chinese language grammar.

Ok, thanks.

codecadwallader · 2017-12-28T12:00:19Z

CodeMaid/StringResourceKey.cs

+
+namespace SteveCadwallader.CodeMaid
+{
+    internal class StringResourceKey : Properties.Resources


I think I know what's going on here, but can you explain this file to me to make sure?

Stringresourcekey is the name of the string resource class that is used by default when Tom-englert/resxresourcemanager is automatically generated. It's not perfect, but it's the best localized translation tool I've ever seen. Use of this file is still to cater to the tool to make the translation faster completion.

Ok, but can you explain what this file is doing to me?

Using resources requires referencing namespace SteveCadwallader.CodeMaid.Properties, but using Stringresourcekey does Not require Stevecadwallader.codemaid, because the root namespace is it. It would be awkward to add namespaces to all required code SteveCadwallader.CodeMaid.Properties.

It looks like this class isn't doing anything at all anymore, so we could delete it and have everything point consistently to Resources. I know it means adding a using statement to do those C# files, but I do not think that is a bad thing and I think it's simpler than having two seeming versions of the resources.

codecadwallader · 2017-12-28T12:05:31Z

CodeMaid/UI/Dialogs/CleanupProgress/CleanupProgressViewModel.cs

@@ -176,7 +176,7 @@ private void backgroundWorker_ProgressChanged(object sender, ProgressChangedEven
            dynamic currentItem = e.UserState;

            CountProgress = currentCount;
-            CurrentFileName = currentItem.Name;
+            CurrentFileName = string.Format(StringResourceKey.Cleaning0, currentItem.Name);


This isn't the current file name anymore, but an output string. I think this was done to avoid using the StringFormat in XAML. If possible it would be preferable to keep the StringFormat in XAML, since this class is a ViewModel.

I tried the XAML stringformat, but it doesn't seem to work.

Ok, another approach would be to split the label into two components then. One for the "Cleaning" which can be translated directly and one for the CurrentFileName. That would allow this ViewModel to be reverted to not having View code in it.

codecadwallader · 2017-12-28T12:06:20Z

CodeMaid/UI/Dialogs/Options/Cleaning/CleaningFileTypesDataTemplate.xaml

@@ -1,6 +1,7 @@
 <ResourceDictionary xmlns="http://schemas.microsoft.com/winfx/2006/xaml/presentation"
        xmlns:x="http://schemas.microsoft.com/winfx/2006/xaml"
        xmlns:local="clr-namespace:SteveCadwallader.CodeMaid.UI.Dialogs.Options.Cleaning"
+        xmlns:properties="clr-namespace:SteveCadwallader.CodeMaid.Properties"


In other files the convention is xmlns:p so it would be good to stick to that here too.

'properties' are the names that Tom-englert/resxresourcemanager use by default, so they are still for faster translation.

I understand a lot of the code was auto-generated by a tool, but we've been really diligent about trying to have as clean of a code base as possible. To accept the pull request the auto-generated code will have to be updated to match conventions of the existing code base.

has been modified ！
91af8fd

codecadwallader · 2017-12-28T12:11:35Z

CodeMaid/UI/Dialogs/Options/OptionsViewModel.cs

                FileName = "CodeMaid",
                DefaultExt = ".config",
-                Filter = "Config files (*.config)|*.config|All Files (*.*)|*.*"
+                Filter = StringResourceKey.OptionsViewModel_OnImportCommandExecuted_ConfigFilesConfigConfigAllFiles


This auto-generated name is very awkward.. perhaps ConfigFileFilter would be clearer.

Yes, it's very long, I submit a refactoring code?

That would be great, thanks.

fix Localizing Menu Commands

…perties " to "xmlns:p="clr-namespace:SteveCadwallader.CodeMaid.Properties"

…into localization

maikebing · 2018-03-07T08:39:25Z

Is there anything else you need to change? @codecadwallader

codecadwallader

It is looking really good and I think we are getting close. I do have a couple continuing requests. Please let me know if you have any questions and thanks for your patience!

codecadwallader · 2018-03-11T12:33:33Z

CodeMaid/CodeMaid.csproj

    <Compile Include="CodeMaid.cs">
-      <AutoGen>True</AutoGen>


Since this is an auto-generated file, I think we need this flag?

codecadwallader · 2018-03-11T12:34:24Z

CodeMaid/Integration/Commands/BaseCommand.cs

@@ -46,6 +46,10 @@ protected BaseCommand(CodeMaidPackage package, CommandID id)
        private static void BaseCommand_BeforeQueryStatus(object sender, EventArgs e)
        {
            BaseCommand command = sender as BaseCommand;
+            //if (string.IsNullOrEmpty(command.Text))


Please remove commented out code.

codecadwallader · 2018-03-11T12:38:08Z

CodeMaid/StringResourceKey.cs

+
+namespace SteveCadwallader.CodeMaid
+{
+    internal class StringResourceKey : Properties.Resources


It looks like this class isn't doing anything at all anymore, so we could delete it and have everything point consistently to Resources. I know it means adding a using statement to do those C# files, but I do not think that is a bad thing and I think it's simpler than having two seeming versions of the resources.

codecadwallader · 2018-03-11T12:40:05Z

CodeMaid/UI/Dialogs/CleanupProgress/CleanupProgressViewModel.cs

@@ -176,7 +176,7 @@ private void backgroundWorker_ProgressChanged(object sender, ProgressChangedEven
            dynamic currentItem = e.UserState;

            CountProgress = currentCount;
-            CurrentFileName = currentItem.Name;
+            CurrentFileName = string.Format(StringResourceKey.Cleaning0, currentItem.Name);


Ok, another approach would be to split the label into two components then. One for the "Cleaning" which can be translated directly and one for the CurrentFileName. That would allow this ViewModel to be reverted to not having View code in it.

…d "StringResourceKey",Modify CleanupProgressViewModel

maikebing · 2018-03-14T02:46:14Z

I have finished. Take the time to review the code!

codecadwallader · 2018-03-17T10:51:22Z

Thank you for the code updates. The code is looking good and I have no further comments. 👍

I pulled down the code and tried to run it locally, but when I startup an experimental instance of Visual Studio the CodeMaid menu is not present at all. I suspect the changes to the .vsct or source.extension files have caused an issue. Can you please look into it?

maikebing · 2018-03-17T10:55:05Z

ResetEnvironment.zip

try this cmd , it reset you VS !

codecadwallader · 2018-03-17T11:34:00Z

Yeah I tried the usual "Reset the Visual Studio 2017 Experimental Instance" batch file that comes with the SDK but it did not fix the issue.

maikebing · 2018-03-18T10:49:02Z

My VS2017 version is 15.6.2. The code I tested under the master branch doesn't seem to be working properly, and I'll find out why.

maikebing · 2018-03-22T16:41:23Z

I tested it and looked normal together.
I uninstalled the codemaid and removed all appdatalocalmicrosoftvisualstudio15.0_f203e778exp. The associated registry key is also deleted.
When I am debugging, I can enter the debugging, also can display the Codemaid menu！

here are also files in the directory
C:\Users\MaiKeBing\AppData\Local\Microsoft\VisualStudio\15.0_f203e778Exp\Extensions\Steve Cadwallader\CodeMaid\10.4

maikebing · 2018-03-22T16:46:01Z

But if I use the parameter/rootsuffix EXP1 then the Codemaid menu does not show

maikebing · 2018-03-22T16:55:32Z

Change the parameters anyway, VS2017 will put codemaid here.
C:\Users\MaiKeBing\AppData\Local\Microsoft\VisualStudio\15.0_f203e778Exp

maikebing · 2018-03-22T16:55:55Z

If you use other parameters, please try “/rootsuffix Exp”

codecadwallader · 2018-03-24T12:01:06Z

Yep /rootsuffix Exp is baked into the repository: https://github.com/codecadwallader/codemaid/blob/master/CodeMaid/CodeMaid.csproj.user#L6

I'm not sure I follow your comments about what you tried and what happened?

codecadwallader · 2018-03-24T12:32:58Z

As a heads up - I just merged another pull request that allows users to turn on/off different features. It looks like your PR will still be able to merge in cleanly, but there are some new user options that will also need setup for translation. A good question is how will we perform translations into Chinese going forwards every time the UI changes? I can use Google Translate, but I know that's not a great source...

maikebing · 2018-03-24T19:13:16Z

It is recommended that you use Microsoft's Bing translation tool

maikebing · 2018-03-24T19:14:16Z

I like codemaid very much, if need, I can translate at any time.

heku · 2018-04-09T12:03:33Z

@codecadwallader Thank you for confirmation. Honestly, I think it's still not easy to give it an easily understood name in Chinese. In my above comment I suggested naming it as 'Code Outline', because the VS has a tool window called 'Document Outline', which is similar with spade tool window.

maikebing · 2018-04-09T16:38:46Z

If CodeMaid is a maid of code, "Spade" has been used in English,I think the direct translation as "A spade for digging code", So it's called 码锹（ Code Spade）， I think it will be a good name.!

heku · 2018-04-10T00:45:19Z

OK, let us use this translation at this stage. I suggest for every localization, open an issue for any feedback and discussion with a title in two languages. For example, for current Chinese localization, it can be “Chinese localization feedback/discussion/suggestion 中文本地化反馈/讨论/建议”. how do you guys think?

This reverts commit 670c99c.

This reverts commit a936156.

翻译改动

codecadwallader · 2018-04-14T12:49:32Z

Ok, to make sure I understand correctly you're saying that each time there is a new feature with new translations needed, new issues should be created for every localization where translation is needed? That seems fine to me.

heku · 2018-04-14T13:50:50Z

Basically Yes, my thought was openning one issue with a title in two language (en+local lang) for every language/localization for any feedback/suggestion. But now I think this might not be a good idea as people always like to create a new issue rather than comment on an existing issue.

Correct a few typos

maikebing · 2018-04-21T02:33:28Z

@heku @codecadwallader Is there any question about this?

heku · 2018-04-21T07:28:14Z

No, I'm fine.

codecadwallader · 2018-04-22T18:21:24Z

There is a minor conflict from another accepted PR. Beyond that, is there anything else pending the two of you have in mind before I review it again?

…into localization

heku · 2018-04-23T12:18:12Z

@codecadwallader I don't have anything to add. @maikebing, I suggest remove the source.extension.resx as it is useless.

maikebing · 2018-04-23T17:32:48Z

source.extension.resx is automatically generated each time !

codecadwallader · 2018-04-28T11:51:47Z

Ok great! Thanks both (especially @maikebing ) for your hard work on this. I will merge it in now and we can review/test from the mainline. :)

codecadwallader · 2018-04-28T11:53:18Z

@heku it looks like some of your .csproj cleanups may have gotten merged out when this got merged into master. It looks like @maikebing did do a merge down from master into this PR branch so I'm not exactly sure why that happened, but perhaps it was too many changes in the same place for Git to resolve.

heku · 2018-05-02T12:39:55Z

@codecadwallader I'll have it a check on your latest code, sorry for the late response as I'm quite busy these days.

maikebing added 2 commits December 19, 2017 15:00

Extract all strings and WPF strings that need to be translated And th…

c1478f9

…e use of TomEnglert.ResXManager for translation work, of which Chinese has been translated.

Add CleanupOnSave

af15fcc

codecadwallader requested changes Dec 28, 2017

View reviewed changes

maikebing added 6 commits January 3, 2018 19:56

https://msdn.microsoft.com/en-us/library/ee943168.aspx

3642dec

fix Localizing Menu Commands

Refactoring a very long localized string variable name

e279ed8

modify "xmlns:properties="clr-namespace:SteveCadwallader.CodeMaid.Pro…

91af8fd

…perties " to "xmlns:p="clr-namespace:SteveCadwallader.CodeMaid.Properties"

Merge remote-tracking branch 'remotes/upstream/master' into localization

d787d61

Merge remote-tracking branch 'remotes/upstream/master' into localization

2be89fb

Merge branch 'localization' of https://github.com/maikebing/codemaid …

bef338f

…into localization

codecadwallader requested changes Mar 11, 2018

View reviewed changes

Modify for PR codecadwallader#506 ,Removed commented out code, Remove…

d2463b7

…d "StringResourceKey",Modify CleanupProgressViewModel

Fix settings translation errors and omissions

79a6d09

maikebing added 2 commits March 25, 2018 03:24

Merge branch 'master' into localization

c51264a

update for PR codecadwallader#525

b5cfccb

Capitalizes programming language name

9cc01b1

heku and others added 8 commits April 10, 2018 21:36

Revert "Update Chinese translation (Spade/Digging -> 代码大纲)"

35d6357

This reverts commit 670c99c.

Revert "Update Chinese translation (Spade/Digging -> 代码视图)"

1b4c4ab

This reverts commit a936156.

#region -> #region(s)

ce7b893

Update a few Chinese translations

ff7922a

Let localization work correctly

b0495c4

Merge pull request #3 from heku/localization

951b8c1

翻译改动

Merge branch 'master' into localization

a960725

Translate the message

2d3f401

heku and others added 2 commits April 14, 2018 22:15

Correct a few typos

0e620ab

Merge pull request #4 from heku/localization

13fee9d

Correct a few typos

maikebing added 3 commits April 23, 2018 10:40

Merge branch 'master' into localization

7f0bc47

restore source.extension.resx

029fa6c

Merge branch 'localization' of https://github.com/maikebing/codemaid …

84a002c

…into localization

codecadwallader approved these changes Apr 28, 2018

View reviewed changes

codecadwallader merged commit ee6363d into codecadwallader:master Apr 28, 2018

maikebing deleted the localization branch April 28, 2018 11:52

The localization of Chinese has been completed #506

The localization of Chinese has been completed #506

Conversation

maikebing commented Dec 19, 2017

maikebing commented Dec 27, 2017

codecadwallader commented Dec 28, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maikebing Jan 3, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maikebing commented Mar 7, 2018

codecadwallader left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maikebing commented Mar 14, 2018

codecadwallader commented Mar 17, 2018

maikebing commented Mar 17, 2018 • edited Loading

codecadwallader commented Mar 17, 2018

maikebing commented Mar 18, 2018

maikebing commented Mar 22, 2018

maikebing commented Mar 22, 2018

maikebing commented Mar 22, 2018

maikebing commented Mar 22, 2018

codecadwallader commented Mar 24, 2018

codecadwallader commented Mar 24, 2018

maikebing commented Mar 24, 2018

maikebing commented Mar 24, 2018

heku commented Apr 9, 2018

maikebing commented Apr 9, 2018

heku commented Apr 10, 2018

codecadwallader commented Apr 14, 2018

heku commented Apr 14, 2018 • edited Loading

maikebing commented Apr 21, 2018

heku commented Apr 21, 2018

codecadwallader commented Apr 22, 2018

heku commented Apr 23, 2018

maikebing commented Apr 23, 2018

codecadwallader commented Apr 28, 2018

codecadwallader commented Apr 28, 2018

heku commented May 2, 2018

maikebing Jan 3, 2018 •

edited

Loading

maikebing commented Mar 17, 2018 •

edited

Loading

heku commented Apr 14, 2018 •

edited

Loading