Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#393: Add ability to clear solution explorer search before finding. #394

Conversation

joeburdick
Copy link
Contributor

This solution works but has one potential drawback. Though the Solution Explorer will stop filtering items by the search query, the query string does not leave the search box. I could not find a way to make this box clear (and I am not even sure that is the behavior one would want.)

@codecadwallader codecadwallader self-assigned this Jan 30, 2017
@codecadwallader
Copy link
Owner

Thanks for putting this together! I pushed some minor tweaks, including promoting when the IServiceProvider is initialized to resolve a unit test execution issue.

I think the text still being present is a little awkward, but since it's an opt-in feature it's something that can be improved upon. Merging in accordingly.

@codecadwallader codecadwallader merged commit 2389943 into codecadwallader:master Jan 30, 2017
@codecadwallader
Copy link
Owner

The CI build with this change can be found here for testing: http://vsixgallery.com/extension/4c82e17d-927e-42d2-8460-b473ac7df316/

@joeburdick joeburdick deleted the ClearSolutionExplorerSearchBeforeFind branch January 3, 2019 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants