Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat code #562

Merged
merged 34 commits into from
Jun 20, 2024
Merged

Reformat code #562

merged 34 commits into from
Jun 20, 2024

Conversation

Shane32
Copy link
Contributor

@Shane32 Shane32 commented Jun 5, 2024

Summary

This PR adds an .editorconfig file along with a workflow to verify that the code matches the workflow. Code throughout the solution has been reformatted to match. Nearly all build warnings are configured as errors, enforcing proper code style both in the editor and via a test workflow.

Process

In general, each warning that I was able to auto-fix, I made a separate commit. Then a few commits to get the CI working and a few more to clean up some last few warnings.

Test plan

  • The code tests and API tests ensure that the code functions correctly and no public API changes have been made.
  • A new workflow has been added to verify that the formatting matches the configured requirements. This does not support the UWP demo app, probably because it's not a SDK format csproj. Also it does not support the .NET Standard 1.3 or .NET Core 1.x TFMs.

Review

To reduce the diff in GitHub, hide whitespace:

image

@Shane32
Copy link
Contributor Author

Shane32 commented Jun 5, 2024

@codebude Ready for review whenever you're ready; no rush.

@codebude codebude merged commit 04d96ff into codebude:master Jun 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants