added collapse keyboard function

[mrwhoknows55]

Closes #84

Added collapseKeyboardOnOutsideTap function in helper module, which can be used in future code also

How has it been tested?

I manually tested it with each edittext and it works fine

Screenshots

[aniri]

hey @mrwhoknows55 ! thanks for your contribution!! the code looks neat, but there seems to be a small glitch when switching the focus from one input to another. for example on the login screen. Could you please check?

[mrwhoknows55]

@aniri will check and fix it

[mrwhoknows55]

@aniri I couldn't find how to solve that, do you have any suggestions?

[aniri]

@mrwhoknows55 I'll also investigate and see if I can come up with something :/

@DeKaN maybe you have a suggestion of how we could fix this? :D we're trying to hide the keyboard when the user presses outside an input area. but on the login screen, if the user switches between inputs for phone and password, the keyboard collapses and then opens again :/

[DeKaN]

@aniri This snippet works well in BaseActivity

    override fun dispatchTouchEvent(ev: MotionEvent): Boolean {
        if (ev.action == MotionEvent.ACTION_UP) {
            currentFocus?.let { oldView ->
                val consumed = super.dispatchTouchEvent(ev)
                val newView = currentFocus ?: oldView
                if (newView == oldView) {
                    val coords = IntArray(2)
                    oldView.getLocationOnScreen(coords)
                    val rect = Rect(coords[0], coords[1], coords[0] + oldView.width, coords[1] + oldView.height)
                    if (rect.contains(ev.x.toInt(), ev.y.toInt()))
                        return consumed
                } else if (newView is EditText) {
                    return consumed
                }

                ContextCompat.getSystemService(this, InputMethodManager::class.java)
                    ?.hideSoftInputFromWindow(newView.windowToken, 0)
                return consumed
            }
        }
        return super.dispatchTouchEvent(ev)
    }

[aniri]

@mrwhoknows55 could you please check the suggestion? ⬆️

[mrwhoknows55]

@aniri it is fixed now, thank you so much @DeKaN 🙏

[aniri]

woooh! looks good now! thanks @mrwhoknows55 & @DeKaN 🚀

just one more nitpick :/ I think we could move the collapseKeyboardIfFocusOutsideEditText method to helper/Utils.kt. It doesn't need to be in a separate file :D

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities (and 0 Security Hotspots to review)
0 Code Smells

No Coverage information
No Duplication information

[mrwhoknows55]

@aniri done!

[aniri]

@mrwhoknows55 awesome! thank you!!

[mrwhoknows55]

@aniri and @DeKaN thank you so much 🙏

[DeKaN]

It's better to return result from line 139 here instead of calling the super method again

[aniri]

good catch! we'll have to fix this in a new PR