Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<video> Player buttons to be added</video> #1445

Open
5 of 29 tasks
ImprovedTube opened this issue Oct 4, 2022 · 6 comments
Open
5 of 29 tasks

<video> Player buttons to be added</video> #1445

ImprovedTube opened this issue Oct 4, 2022 · 6 comments
Assignees
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) Player-Button Feature should only take one click/impulse to toggle/tune Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥

Comments

@ImprovedTube
Copy link
Member

ImprovedTube commented Oct 4, 2022

List of missing player buttons (Global and/or YouTube)

content-based buttons (youtube only) :

  • not only button, but a universal (little) <Input> at once - for Search in Captions & Comments at once should appear in line with important buttons https://github.com/sonigy/YCS.

    • skip video to first matching line; open transcript; show comments filtered&marked up.
      - ( 2. Typing 'some words at start ... end can define a section/chapter/refrain/verse, if "..." becomes a .*? regex applied on the transcript of the video. So this can also defined a &start= &end= time mark for bookmarking or sharing) - and that section could then play in a loop and be seen in the looper element's icon...)
  • Filtering 'too popular' stuff: Strategic blocking based on category, popularity & monoculture #1451
    (Many people want to "set & forget", but this should be accompanied by a a dynamic button. (It could be an slider on mouse-over (like volume. Ranging from 0-100), and indicate the value calculated for the current video/channel)

Player buttons Layout

  • These Buttons can be enabled in one row by default, like Youtube Enhancer has by now too, but with decreasing size&opacity by relevance. They can also appear at all edges on mouse over and intentional mouse direction (not random)
    youtube player buttons ( Without overlapping the video, buttons could stay permanently, but still can be a filtered / contextual selection / transparency. And optional only appear on mouse over (along with youtube's controls) )

Rationale

While usally temporary (one-time-use) on left click,
on right-click, every button could also allow to build specific sticky-rules! ( 'always for this channel' / ...category ...'keyword/tag:....' (added to a list 'my rules' - Such ideas will arise while experiencing content - not while staring at our menus) (abstract for non-developers)

  • (in turn each button can later indicate auto-active state through such rule with a slightly pink frame/glow or so, to possibly remind of it incase a forgotten rule needs an refinemen/exception. Right click: 'exclude this video/channel/category [from my skipping rules(whitelist)]'

"I'd like that (popout button enabled by default). Otherwise as a new user (first install two days ago) I found it hard to know what the extension could do." (#860 (comment)) )

@ImprovedTube
Copy link
Member Author

ImprovedTube commented Oct 4, 2022

compact button-layout for both speed & frame-by-frame:

<- (1.0) ->

A little input, with two buttons left & right ('slower' & 'faster'. But 'previous frame' & 'next frame' when paused)

  • the Input should remember the value at last usage, but only activate it for another video when clicking the input again
    • so this one element is enough for most of all manual uses of speed. Some people also wish for mulitple speeds, but then it could be automated by rules rather categories music 1x, news 1.5x, lengthy-walkthroughs 2x.)

  • alternatively the element can also support scrolling at mouse-over )

  • and this input could also be draggable (like a joystick or an "invisible slider", so that the number in the input will change when dragging it. (while a permanent slider would need more space and have more accidental clicks)

    • (and to avoid accidental dragging abort when dragged diagonally rather than horizontally or vertically)
      • this will also allow to speed up temporarily before aborting by changing the mouse direction (like a DJ turntable)
        • (edit 2024: btw youtube added: click&hold for speed.)

@ImprovedTube ImprovedTube added 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. Player-Button Feature should only take one click/impulse to toggle/tune labels Oct 4, 2022
@ImprovedTube ImprovedTube changed the title Player buttons <video> Player buttons </video> Oct 6, 2022
@ImprovedTube ImprovedTube changed the title <video> Player buttons </video> <video> Missing Player buttons </video> Oct 10, 2022
@ImprovedTube ImprovedTube changed the title <video> Missing Player buttons </video> <video> Player buttons to be added</video> Jan 21, 2023
@ImprovedTube ImprovedTube mentioned this issue Mar 24, 2023
20 tasks
@ImprovedTube ImprovedTube added the Feature request Wish or idea label May 1, 2023
@ImprovedTube ImprovedTube removed their assignment May 10, 2023
@xiomaraR
Copy link

xiomaraR commented May 2, 2024

I'd like to help with one of the more beginner friendly tasks, which would you recommend?

@ImprovedTube
Copy link
Member Author

ImprovedTube commented May 3, 2024

hi & thanks! @xiomaraR
Depends what category you like to try.

Mentioning a lot, since each can be broken down into sub-tasks. And just publishing a note/blog can be valuable:

  • Documentation / Writing down thoughts beneficial to the public. Or specifically here: How-To's (If no sufficient answer about something is found/published, then (as a side-effect) one should already have written down the final question title and keywords or title to publish. So after figuring out, then answering oneself, right-away, without forgetting the process can make it efficient.)

  • Code navigation / searching in the repo (not always easy, potentially annoying, but often just one thing at a time)

    • Bugs
    • Updates after youtube's changes (CSS selectors, etc. )
      • Example: we already have a 'Play all' button on channel pages, but it might not appear anymore? (current version). It would be nice to appear in more places too, where people like it. Or with a shortcut key.
  • Development / engineering

    • Classic: functionality code. Feature requests. Might has labels like set&forget, unique or plan-ready Not required to integrate into the UI immediately nor alone). Example | 2
    • "Rich-"Data: Working with data might be more powerful, inspiring (once working with any JSON and queries at all)
      example:
        • Skip to next key scene data-source: #1463
  • Code integration (there is a lot of free code, that isn't popular yet #1881)

  • UX:

    • might starts with thinking of the typical use-case (or the whole spectrum if possible once) (and watching usage statistics/analytics if possible/available)
      • Structure
      • Example: Currently we allow (at most) these buttons, without setting specific order or position youtube buttons (the right ones can be collapsed including Youtube's the left ones cant.).
        • Optionally this can be compared with how others do it: YouTube enhancer, Magic Actions for Youtube.
      • Example 2
      • Example 3
    • UI: Who wants to implement the UX advantages?


  • Mirror (for dancing along or play alone guitar, drums,.... & some other thus other HowTo's/DIY/Cooking (exists)

@xiomaraR
Copy link

xiomaraR commented May 3, 2024

@ImprovedTube thanks for the summary/outline! I will give it all some more consideration as I get more comfortable with the codebase. For now, I'd like to try updating the mirror button. Is there a specific ticket?

@ImprovedTube
Copy link
Member Author

Aand two more types of tasks:

@ImprovedTube
Copy link
Member Author

ImprovedTube commented May 5, 2024

hi! @xiomaraR, thanks and glad if it wasn't too much to read. Let's make this list of types of tasks a wiki page here?
We don't have a mirror button yet. (closed #80. Once added, we can checkbox it above.)

  • You could start with a copy of the rotate button, adjusting the names & CSS-injection.
    • The function in player.js is the main thing; in our menu Mirror can be listed below Rotate (and you don't have to add it to all the language files, but only to /en/messages.json; while the first search result ("core.js") is only for this: "// REACTION OR VISUAL FEEDBACK WHEN THE USER CHANGES A SETTING (already automated for our CSS features)" ) as written above it)
    • So while wanted & minimal, it is ultimately a task AI should do. And for you personally it might only serve to get familiar with webExtensions & this repo (i saw you have a github history👍). And mirror isn't immediately a unique feature (existing solution with 30 000 users, forgot to link it at first). So, while i initially though of suggesting Mirror as a beginner-friendly example, it ended up as an example for this type of task instead ( Assessing / Re-evaluating plans)
      and i added this sub-task: ( above )
        • remember per video or per selection, if a loop is or will be set too for this video. (compare: mirrortube )
        • Once we will have that too, it will be a unique product, improvement to all users.
          • aand this makes me remember to add: " - [ ] transpose. Compare: transpose pitch speed loop (700 000 users) (Once we add all three things, that would apparently make this extension the best youtube extension for musicians already.)
      • So that will be amazing but take 2 or more tasks, which is why it wasn't among the first 3 examples i mentioned:
        AFAIK pause while typing will be unique. And moving Subtitles/Captions below the player will be unique too. (remembered these through checking the labels: #unique, #set&forget, #plan-ready)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bounty Will pass on donations (Optional) - (OR: Requester will pay personally. Only if stated!) Feature request Wish or idea good first issue A GitHub standard for inviting (new) contributors *Congratulations in advance!* help wanted Just an old github standard we add automatically. (The team can remove it when working on it.) List of tasks Efficient to have a List for this (sub-)project. (Each task might be worth an extra thread.) 🧩Plan ready Solution or some specification noted; To-Do; steps for implementation (+raw brainstorming too maybe) Player-Button Feature should only take one click/impulse to toggle/tune Structures (UX) & ORG Let's focus on structure! Everything should be as easily seen/found as or where it is relevant. ✰Unique unique ~ Worth extra work (not done anywhere in any way? out of the box?) up-for-grabs (a github standard for inviting new contributors) - Welcome! ♥
Projects
Status: Todo
Development

No branches or pull requests

4 participants