Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input Component #5

Merged
merged 12 commits into from
Dec 9, 2023
Merged

Input Component #5

merged 12 commits into from
Dec 9, 2023

Conversation

nicosammito
Copy link
Contributor

No description provided.

@nicosammito nicosammito added the enhancement New feature or request label Dec 7, 2023
@nicosammito nicosammito self-assigned this Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/base-ui/-/pipelines/1101357019

Status: Passed
Duration: 47 seconds

Job summaries

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/base-ui/-/jobs/5718042906/artifacts/storybook-static/index.html

Copy link
Member

@Taucher2003 Taucher2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also see some files are missing a final newline, please fix this 🙂

.storybook/theme.js Show resolved Hide resolved
package.json Show resolved Hide resolved
src/components/input/Input.stories.tsx Show resolved Hide resolved
src/components/input/Input.style.scss Show resolved Hide resolved
src/components/input/Input.style.scss Show resolved Hide resolved
Copy link
Member

@Taucher2003 Taucher2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without specific react knowledge and without being a css expert, this looks ok to me

@nicosammito nicosammito merged commit 4d7a814 into main Dec 9, 2023
1 check passed
@nicosammito nicosammito deleted the input branch December 9, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants