Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tooltip + Dropdown fix #37

Merged
merged 13 commits into from
Jan 4, 2024
Merged

Tooltip + Dropdown fix #37

merged 13 commits into from
Jan 4, 2024

Conversation

nicosammito
Copy link
Contributor

@nicosammito nicosammito commented Dec 27, 2023 •
edited
Loading

Close #32
Close #38

@nicosammito nicosammito added bug Something isn't working enhancement New feature or request labels Dec 27, 2023
@nicosammito nicosammito self-assigned this Dec 27, 2023
@nicosammito nicosammito added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Dec 27, 2023
@nicosammito
Copy link
Contributor Author

@Taucher2003 error with your pipeline

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 27, 2023 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/pictor/-/pipelines/1126280544

Status: Passed
Duration: 2 minutes

Job summaries

docs:preview

Documentation preview available at https://code0-tech.gitlab.io/-/telescopium/-/jobs/5857010037/artifacts/dist/index.html

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/pictor/-/jobs/5857003826/artifacts/storybook-static/index.html

@Taucher2003 Taucher2003 added regenerate-snapshots Starts a pipeline to regenerate image snapshots and removed regenerate-snapshots Starts a pipeline to regenerate image snapshots labels Dec 27, 2023
@Taucher2003 Taucher2003 removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Dec 27, 2023
@nicosammito nicosammito added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Dec 28, 2023
@github-actions github-actions bot removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Dec 28, 2023
@nicosammito nicosammito marked this pull request as draft December 28, 2023 17:40
@nicosammito nicosammito marked this pull request as ready for review January 2, 2024 08:23
Taucher2003
Taucher2003 reviewed Jan 2, 2024
View reviewed changes
src/components/button/Button.stories.tsx Outdated Show resolved Hide resolved
src/components/tooltip/Tooltip.tsx Outdated Show resolved Hide resolved
@nicosammito nicosammito merged commit 561377e into main Jan 4, 2024
1 check passed
@nicosammito nicosammito deleted the tooltip branch January 4, 2024 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taucher2003 Taucher2003 Taucher2003 approved these changes

@raphael-goetz raphael-goetz Awaiting requested review from raphael-goetz

Assignees

@nicosammito nicosammito

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tooltip + Dropdown alignment Tooltip Component
2 participants
@nicosammito @Taucher2003