Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Badge Component #31

Merged
merged 4 commits into from
Dec 24, 2023
Merged

Badge Component #31

merged 4 commits into from
Dec 24, 2023

Conversation

nicosammito
Copy link
Contributor

Close #10

@nicosammito nicosammito added the enhancement New feature or request label Dec 22, 2023
@nicosammito nicosammito self-assigned this Dec 22, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 22, 2023 •
edited
Loading

GitLab Pipeline Action

General information

Link to pipeline: https://gitlab.com/code0-tech/pictor/-/pipelines/1118211458

Status: Passed
Duration: 3 minutes

Job summaries

storybook:build

Storybook available at https://code0-tech.gitlab.io/-/pictor/-/jobs/5816650659/artifacts/storybook-static/index.html

@Taucher2003
Copy link
Member

Primary is basically just text. The badge is only visible when a variant other than "primary" is used. That feels weird

image

@nicosammito
Copy link
Contributor Author

Primary is basically just text. The badge is only visible when a variant other than "primary" is used. That feels weird

image

No that's absolutely the way it should work. We want to highlight the badge so we usually use a different variant. That's the general use case

@Taucher2003 Taucher2003 added the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Dec 24, 2023
@github-actions github-actions bot removed the regenerate-snapshots Starts a pipeline to regenerate image snapshots label Dec 24, 2023
@nicosammito nicosammito merged commit 7581ba6 into main Dec 24, 2023
1 check passed
@nicosammito nicosammito deleted the badges branch December 24, 2023 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Taucher2003 Taucher2003 Taucher2003 approved these changes

@raphael-goetz raphael-goetz Awaiting requested review from raphael-goetz

Assignees

@nicosammito nicosammito

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Badge Component
2 participants
@nicosammito @Taucher2003