Enable contrast test #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitLab Pipeline ActionGeneral informationLink to pipeline: https://gitlab.com/code0-tech/base-ui/-/pipelines/1110127018 Status: Passed Job summariesstorybook:buildStorybook available at https://code0-tech.gitlab.io/-/base-ui/-/jobs/5769418078/artifacts/storybook-static/index.html |
The contrast test was disabled as it was not able to work with gradients. We have now decided to not use gradients, so the test can be re-enabled
Axe needs to be injected after the page has loaded. If it is injected before, it fails on some non-existent contrast problems. It seems that it checks the contrast during the loading transition of storybook, so it creates a flaky failure on the contrast test
Taucher2003
force-pushed
the
enable-contrast-test
branch
from
74145da
to
1f91189
Compare
When the input is disabled, it should be marked as aria-disabled. This also clears the color contrast violation for the 50% opacity as the element is semantically marked as disabled.
When the button is disabled, it should be marked as aria-disabled. This also clears the color contrast violation for the 50% opacity as the element is semantically marked as disabled.
Taucher2003
force-pushed
the
enable-contrast-test
branch
from
1f91189
to
5553be3
Compare
nicosammito
approved these changes
Dec 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The contrast test was disabled as it was not able to work with gradients. We have now decided to not use gradients, so the test can be re-enabled.