Merge pull request #88 from code0-tech/quote-logo-requierement

switch logo to non requirements for quote component
code0-tech · May 6, 2024 · a376fb7 · a376fb7
2 parents dfbf1fb + 0f0bc43
commit a376fb7
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 7 deletions.
diff --git a/__snapshots__/quote--quote-sample-chromium.png b/__snapshots__/quote--quote-sample-chromium.png
diff --git a/__snapshots__/quote--quote-sample-firefox.png b/__snapshots__/quote--quote-sample-firefox.png
diff --git a/__snapshots__/quote--quote-sample-webkit.png b/__snapshots__/quote--quote-sample-webkit.png
diff --git a/src/components/quote/Quote.stories.tsx b/src/components/quote/Quote.stories.tsx
@@ -39,10 +39,7 @@ type QuoteStory = StoryObj<typeof Quote>;
 export const QuoteSample: QuoteStory = {
     render: (args) => {
         return <Quote {...args} name={"Nico Sammito"}
-                      style={{height: "200px"}}
-                      logo={"https://avatars.githubusercontent.com/u/150623800?s=200&v=4"}
                       position={"Co-founder"}
-                      mt={10}
                       w={"300px"}>
             My favorite UX feedback from customers is:
             "How is the app so fast?"

diff --git a/src/components/quote/Quote.tsx b/src/components/quote/Quote.tsx
@@ -5,7 +5,7 @@ import Text from "../Text/Text";
 
 export interface QuoteType extends Omit<CardType, "children"> {
     children: string
-    logo: string
+    logo?: string
     name: string
     position: string
     // defaults to true
@@ -21,9 +21,11 @@ const Quote: React.FC<QuoteType> = (props) => {
                     {children}
                 </div>
             </Card.Section>
-            <Card.Section>
-                <img className={"quote__img"} src={logo} alt={"logo of quote"}/>
-            </Card.Section>
+            {
+                !!logo ? <Card.Section>
+                    <img className={"quote__img"} src={logo} alt={"logo of quote"}/>
+                </Card.Section> : null
+            }
             <Card.Section>
                 <Text size={"md"} hierarchy={"primary"}>{name}</Text><br/>
                 <Text size={"sm"}>{position}</Text>