Skip to content
This repository has been archived by the owner on Mar 16, 2024. It is now read-only.

Improve test stability #64

Merged
merged 3 commits into from
Jul 24, 2022
Merged

Improve test stability #64

merged 3 commits into from
Jul 24, 2022

Conversation

JonasScholl
Copy link
Collaborator

@JonasScholl JonasScholl commented Jul 24, 2022

Following adjustments have been made in order to increase test stability:

  • fix non-deterministic timeout test
  • increase possible time to wait for test infrastructure to be available

We use httpretty for the timeout test, and there's a bug with simulating timeouts there: https://github.com/gabrielfalcao/HTTPretty/issues/438?ref=pythonrepo.com We get the error printed out, but it doesn't affect our tests. So I suggest to ignore it until it is fixed

Additionally I updated fastapi, we might also switch to poetry with dependabot since our current dependency handling is kind of chaotic and unmanaged... what do you think @yannicschroeer?

@JonasScholl JonasScholl added the bug Something isn't working label Jul 24, 2022
Copy link
Collaborator

@yannicschroeer yannicschroeer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks 👍

@JonasScholl JonasScholl merged commit 930934f into master Jul 24, 2022
@JonasScholl JonasScholl deleted the improve-test-stability branch July 24, 2022 14:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants