Custom Shortcuts Issues

[hboyd2003]

Edit by @ImprovedTube

• #BUG: The "Reset-Button" visually works & closes our shortcut setting dialogue but then does not "save"

  • it is broken here: https://github.com/code-for-charity/SATUS/blob/08087e631c0e48b4303080791d6a0a1381ffe398/satus.js#L2550
    ( same line of code for color picker reset works tho https://github.com/code-for-charity/SATUS/blob/08087e631c0e48b4303080791d6a0a1381ffe398/satus.js#L1923 )

  • but still worked here (Sep2021): https://github.com/code-for-charity/ImprovedTube-for-YouTube/blob/70c7f03a12c51ac7736dbc740d073b417bc6f135/satus.js#L1644

---

+Confusing:

• Right after setting a shortcut (for example "Screenshot", then the the action happen once without pressing anything.
  But it actually only works on the next page / after reloading
  • instead, we can trigger the required page reload every time a shortcut is set...

&

• there should be a note/reminder when setting the same shortcut for multiple things

---

---

This bug report was made to consolidate various "Shortcut" reports

Bug Report:

⚬ BUG: All? custom shortcuts do not work

⚬ HOW: Assign any shortcut a key (that differs from Youtube's default shortcuts) and attempt to use it.

⚬ EXPECTED (/preferred) behavior: Pressing a shortcut key works

[mrangjunboon2017s]

what

[ImprovedTube]

hi @mrangjunboon2017s, farewell 1337

[hboyd2003]

@ImprovedTube Are any of the shortcuts working for you?

[ImprovedTube]

Works besides: ..... scroll to top

[BRAVO68WEB]

Will check on this

[ImprovedTube]

#BUG: The "Reset-Button" closes our shortcut setting dialogue but then does not "save"

yay!! @BRAVO68WEB ( this is just one important thing that might be good to get to know the code😳)

(if you see the "project" "bugs v4", on the right of this issues, then you see i added that it still worked in 3.965. This means with the old Satus, so the fix might possibly belong there too https://github.com/code-for-charity/SATUS .
The Browser Extension repo will get the source code from there)

[ImprovedTube]

#862