Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix node checking so we work on browsers and node #47

Merged
merged 1 commit into from
Oct 26, 2018

Conversation

cpirich
Copy link
Contributor

@cpirich cpirich commented Oct 26, 2018

@codecov-io
Copy link

Codecov Report

Merging #47 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #47   +/-   ##
=======================================
  Coverage   34.62%   34.62%           
=======================================
  Files           4        4           
  Lines         543      543           
=======================================
  Hits          188      188           
  Misses        355      355
Impacted Files Coverage Δ
src/loadP5.js 57.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7250460...63688bd. Read the comment docs.

Copy link
Contributor

@epeach epeach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not super familiar with webpack and the cause of this error, but LGTM.

@cpirich cpirich merged commit babcd49 into master Oct 26, 2018
@cpirich cpirich deleted the fix_node_checking branch October 26, 2018 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants