fixed issue #1516 #1562
Merged
fixed issue #1516 #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thank you @MohamedLebda wonderful! (just gotta ignore white-spaces to review it efficently https://github.com/code-for-charity/ImprovedTube-for-YouTube/pull/1562/files#diff-172cb39a6665f80ce0e399395668737ccdb529e134268202edc74d6d5df0ceb9 ) |
|
fixed the white-spaces issue |
ohhh :) hope this was funny / Didnt mean to be picky there. |
|
No, that was my fault I forget about prettier changing the indentation which made reviewing the code very hard |
|
(we can use 'prettier' on the whole repo tho) |
This was referenced Feb 19, 2023
Closed
ImprovedTube
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
first checked if there is a new tab opened then checked if the new tab has another video playing